Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more informative error message on crate publish when github org doesn't have the right oauth permissions #932

Open
Manishearth opened this issue Aug 2, 2017 · 1 comment
Labels
A-accounts C-bug 🐞 Category: unintended, undesired behavior E-help-wanted

Comments

@Manishearth
Copy link
Member

So today I tried publishing the app_units crate.

I got the error error: api errors: crate name has already been claimed by another user.

Except I've published this crate before.

I poked deeper and the crate owners are glennw and servo:cargo-publish. I am a member of the cargo-publish org.

It turns out that Servo had tightened up org security, and one thing that was done was disallow access to all OAuth applications by default, with opt-in. So crates.io was unable to figure out who servo:cargo-publish consists of, and instead of giving a helpful error, it just told me I wasn't an owner.

It should give an error like "If you are a member of the cargo-publish group on the servo github org, please get servo to approve crates.io by following these steps" instead, I suspect GitHub does return a particular error code when an OAuth app is unable to access an org.

(crates.io issue because I'm sure cargo doesn't have enough info to compute this)

@carols10cents carols10cents added the C-bug 🐞 Category: unintended, undesired behavior label Aug 2, 2017
@carols10cents
Copy link
Member

yep. We've seen this problem with people adding a team as an owner and we've tried to add some more docs around this issue. This is another case we should give more info on and point to those docs and give specific instructions in the error message :-/

@carols10cents carols10cents changed the title Show more informative error message if crate authors are not fully known Show more informative error message on crate publish when github org doesn't have permission Aug 2, 2017
@carols10cents carols10cents changed the title Show more informative error message on crate publish when github org doesn't have permission Show more informative error message on crate publish when github org doesn't have the right oauth permissions Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-accounts C-bug 🐞 Category: unintended, undesired behavior E-help-wanted
Projects
None yet
Development

No branches or pull requests

2 participants