From a1c0fc306c32bc741bb6cd8cdc611b92f0c92708 Mon Sep 17 00:00:00 2001 From: n4n5 Date: Wed, 16 Jul 2025 12:39:47 -0600 Subject: [PATCH] frontend: add quote to crate name --- app/routes/crate.js | 4 ++-- e2e/acceptance/crate-dependencies.spec.ts | 4 ++-- e2e/acceptance/crate.spec.ts | 4 ++-- e2e/routes/crate/range.spec.ts | 4 ++-- tests/acceptance/crate-dependencies-test.js | 4 ++-- tests/acceptance/crate-test.js | 4 ++-- tests/routes/crate/range-test.js | 4 ++-- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/app/routes/crate.js b/app/routes/crate.js index b7efbbc449f..1e2e0f2f9e5 100644 --- a/app/routes/crate.js +++ b/app/routes/crate.js @@ -23,10 +23,10 @@ export default class CrateRoute extends Route { return crate; } catch (error) { if (error instanceof NotFoundError) { - let title = `${crateName}: Crate not found`; + let title = `'${crateName}': Crate not found`; this.router.replaceWith('catch-all', { transition, error, title }); } else { - let title = `${crateName}: Failed to load crate data`; + let title = `'${crateName}': Failed to load crate data`; this.router.replaceWith('catch-all', { transition, error, title, tryAgain: true }); } } diff --git a/e2e/acceptance/crate-dependencies.spec.ts b/e2e/acceptance/crate-dependencies.spec.ts index 401c2cb1673..bb3a4ec1bd0 100644 --- a/e2e/acceptance/crate-dependencies.spec.ts +++ b/e2e/acceptance/crate-dependencies.spec.ts @@ -34,7 +34,7 @@ test.describe('Acceptance | crate dependencies page', { tag: '@acceptance' }, () await page.goto('/crates/foo/1.0.0/dependencies'); await expect(page).toHaveURL('/crates/foo/1.0.0/dependencies'); await expect(page.locator('[data-test-404-page]')).toBeVisible(); - await expect(page.locator('[data-test-title]')).toHaveText('foo: Crate not found'); + await expect(page.locator('[data-test-title]')).toHaveText(`'foo': Crate not found`); await expect(page.locator('[data-test-go-back]')).toBeVisible(); await expect(page.locator('[data-test-try-again]')).toHaveCount(0); }); @@ -45,7 +45,7 @@ test.describe('Acceptance | crate dependencies page', { tag: '@acceptance' }, () await page.goto('/crates/foo/1.0.0/dependencies'); await expect(page).toHaveURL('/crates/foo/1.0.0/dependencies'); await expect(page.locator('[data-test-404-page]')).toBeVisible(); - await expect(page.locator('[data-test-title]')).toHaveText('foo: Failed to load crate data'); + await expect(page.locator('[data-test-title]')).toHaveText(`'foo': Failed to load crate data`); await expect(page.locator('[data-test-go-back]')).toHaveCount(0); await expect(page.locator('[data-test-try-again]')).toBeVisible(); }); diff --git a/e2e/acceptance/crate.spec.ts b/e2e/acceptance/crate.spec.ts index bf09fe3628b..7c8243a6ac3 100644 --- a/e2e/acceptance/crate.spec.ts +++ b/e2e/acceptance/crate.spec.ts @@ -81,7 +81,7 @@ test.describe('Acceptance | crate page', { tag: '@acceptance' }, () => { await page.goto('/crates/nanomsg'); await expect(page).toHaveURL('/crates/nanomsg'); await expect(page.locator('[data-test-404-page]')).toBeVisible(); - await expect(page.locator('[data-test-title]')).toHaveText('nanomsg: Crate not found'); + await expect(page.locator('[data-test-title]')).toHaveText(`'nanomsg': Crate not found`); await expect(page.locator('[data-test-go-back]')).toBeVisible(); await expect(page.locator('[data-test-try-again]')).toHaveCount(0); }); @@ -92,7 +92,7 @@ test.describe('Acceptance | crate page', { tag: '@acceptance' }, () => { await page.goto('/crates/nanomsg'); await expect(page).toHaveURL('/crates/nanomsg'); await expect(page.locator('[data-test-404-page]')).toBeVisible(); - await expect(page.locator('[data-test-title]')).toHaveText('nanomsg: Failed to load crate data'); + await expect(page.locator('[data-test-title]')).toHaveText(`'nanomsg': Failed to load crate data`); await expect(page.locator('[data-test-go-back]')).toHaveCount(0); await expect(page.locator('[data-test-try-again]')).toBeVisible(); }); diff --git a/e2e/routes/crate/range.spec.ts b/e2e/routes/crate/range.spec.ts index 01a391d7f22..fa61539663f 100644 --- a/e2e/routes/crate/range.spec.ts +++ b/e2e/routes/crate/range.spec.ts @@ -76,7 +76,7 @@ test.describe('Route | crate.range', { tag: '@routes' }, () => { await page.goto('/crates/foo/range/^3'); await expect(page).toHaveURL('/crates/foo/range/%5E3'); await expect(page.locator('[data-test-404-page]')).toBeVisible(); - await expect(page.locator('[data-test-title]')).toHaveText('foo: Crate not found'); + await expect(page.locator('[data-test-title]')).toHaveText(`'foo': Crate not found`); await expect(page.locator('[data-test-go-back]')).toBeVisible(); await expect(page.locator('[data-test-try-again]')).toHaveCount(0); }); @@ -87,7 +87,7 @@ test.describe('Route | crate.range', { tag: '@routes' }, () => { await page.goto('/crates/foo/range/^3'); await expect(page).toHaveURL('/crates/foo/range/%5E3'); await expect(page.locator('[data-test-404-page]')).toBeVisible(); - await expect(page.locator('[data-test-title]')).toHaveText('foo: Failed to load crate data'); + await expect(page.locator('[data-test-title]')).toHaveText(`'foo': Failed to load crate data`); await expect(page.locator('[data-test-go-back]')).toHaveCount(0); await expect(page.locator('[data-test-try-again]')).toBeVisible(); }); diff --git a/tests/acceptance/crate-dependencies-test.js b/tests/acceptance/crate-dependencies-test.js index a9ac5227f03..e7e63e99b7b 100644 --- a/tests/acceptance/crate-dependencies-test.js +++ b/tests/acceptance/crate-dependencies-test.js @@ -46,7 +46,7 @@ module('Acceptance | crate dependencies page', function (hooks) { await visit('/crates/foo/1.0.0/dependencies'); assert.strictEqual(currentURL(), '/crates/foo/1.0.0/dependencies'); assert.dom('[data-test-404-page]').exists(); - assert.dom('[data-test-title]').hasText('foo: Crate not found'); + assert.dom('[data-test-title]').hasText(`'foo': Crate not found`); assert.dom('[data-test-go-back]').exists(); assert.dom('[data-test-try-again]').doesNotExist(); }); @@ -57,7 +57,7 @@ module('Acceptance | crate dependencies page', function (hooks) { await visit('/crates/foo/1.0.0/dependencies'); assert.strictEqual(currentURL(), '/crates/foo/1.0.0/dependencies'); assert.dom('[data-test-404-page]').exists(); - assert.dom('[data-test-title]').hasText('foo: Failed to load crate data'); + assert.dom('[data-test-title]').hasText(`'foo': Failed to load crate data`); assert.dom('[data-test-go-back]').doesNotExist(); assert.dom('[data-test-try-again]').exists(); }); diff --git a/tests/acceptance/crate-test.js b/tests/acceptance/crate-test.js index 7cba451bec6..5e2c9a95c17 100644 --- a/tests/acceptance/crate-test.js +++ b/tests/acceptance/crate-test.js @@ -87,7 +87,7 @@ module('Acceptance | crate page', function (hooks) { await visit('/crates/nanomsg'); assert.strictEqual(currentURL(), '/crates/nanomsg'); assert.dom('[data-test-404-page]').exists(); - assert.dom('[data-test-title]').hasText('nanomsg: Crate not found'); + assert.dom('[data-test-title]').hasText(`'nanomsg': Crate not found`); assert.dom('[data-test-go-back]').exists(); assert.dom('[data-test-try-again]').doesNotExist(); }); @@ -98,7 +98,7 @@ module('Acceptance | crate page', function (hooks) { await visit('/crates/nanomsg'); assert.strictEqual(currentURL(), '/crates/nanomsg'); assert.dom('[data-test-404-page]').exists(); - assert.dom('[data-test-title]').hasText('nanomsg: Failed to load crate data'); + assert.dom('[data-test-title]').hasText(`'nanomsg': Failed to load crate data`); assert.dom('[data-test-go-back]').doesNotExist(); assert.dom('[data-test-try-again]').exists(); }); diff --git a/tests/routes/crate/range-test.js b/tests/routes/crate/range-test.js index 26d2daa9009..056e1ce9d8e 100644 --- a/tests/routes/crate/range-test.js +++ b/tests/routes/crate/range-test.js @@ -84,7 +84,7 @@ module('Route | crate.range', function (hooks) { await visit('/crates/foo/range/^3'); assert.strictEqual(currentURL(), '/crates/foo/range/%5E3'); assert.dom('[data-test-404-page]').exists(); - assert.dom('[data-test-title]').hasText('foo: Crate not found'); + assert.dom('[data-test-title]').hasText(`'foo': Crate not found`); assert.dom('[data-test-go-back]').exists(); assert.dom('[data-test-try-again]').doesNotExist(); }); @@ -96,7 +96,7 @@ module('Route | crate.range', function (hooks) { await visit('/crates/foo/range/^3'); assert.strictEqual(currentURL(), '/crates/foo/range/%5E3'); assert.dom('[data-test-404-page]').exists(); - assert.dom('[data-test-title]').hasText('foo: Failed to load crate data'); + assert.dom('[data-test-title]').hasText(`'foo': Failed to load crate data`); assert.dom('[data-test-go-back]').doesNotExist(); assert.dom('[data-test-try-again]').exists(); });