Skip to content

Commit d2e6be3

Browse files
committed
add build-result (success/fail/error) to build-time metric
1 parent 12494b8 commit d2e6be3

File tree

1 file changed

+17
-1
lines changed

1 file changed

+17
-1
lines changed

crates/bin/docs_rs_builder/src/build_queue.rs

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ use docs_rs_context::Context;
66
use docs_rs_fastly::CdnBehaviour as _;
77
use docs_rs_logging::BUILD_PACKAGE_TRANSACTION_NAME;
88
use docs_rs_utils::{Handle, retry};
9+
use opentelemetry::KeyValue;
910
use std::time::Instant;
1011
use tracing::{error, info_span};
1112

@@ -25,7 +26,22 @@ fn process_next_crate(
2526
let instant = Instant::now();
2627
let res = f(to_process);
2728
let elapsed = instant.elapsed().as_secs_f64();
28-
builder_metrics.build_time.record(elapsed, &[]);
29+
builder_metrics.build_time.record(
30+
elapsed,
31+
&[KeyValue::new(
32+
"result",
33+
match &res {
34+
Ok(summary) => {
35+
if summary.successful {
36+
"success"
37+
} else {
38+
"failed"
39+
}
40+
}
41+
Err(_) => "error",
42+
},
43+
)],
44+
);
2945
res
3046
};
3147

0 commit comments

Comments
 (0)