File tree Expand file tree Collapse file tree 1 file changed +4
-4
lines changed Expand file tree Collapse file tree 1 file changed +4
-4
lines changed Original file line number Diff line number Diff line change @@ -395,7 +395,7 @@ fn evaluate_pendings() -> DashResult<()> {
395395                        proposal. id,  why) ) ; 
396396        } 
397397
398-         let  majority_complete = num_outstanding_reviews < num_complete_reviews; 
398+         let  majority_complete = num_outstanding_reviews <=  2   *  num_complete_reviews; 
399399
400400        if  num_active_concerns == 0  && majority_complete && num_outstanding_reviews < 3  { 
401401            // TODO only record the fcp as started if we know that we successfully commented 
@@ -1197,9 +1197,9 @@ impl<'a> RfcBotComment<'a> {
11971197                    } 
11981198                } 
11991199
1200-                 msg. push_str ( "\n Once a majority  of reviewers approve (and at most 2 approvals are outstanding),  " ) ; 
1201-                 msg. push_str ( "this will enter its final comment period.  " ) ; 
1202-                 msg. push_str ( "If you spot a major issue that hasn't been raised " ) ; 
1200+                 msg. push_str ( "\n Once two thirds  of reviewers approve (and at most 2 " ) ; 
1201+                 msg. push_str ( "approvals are outstanding),  this will enter its final comment " ) ; 
1202+                 msg. push_str ( "period.  If you spot a major issue that hasn't been raised " ) ; 
12031203                msg. push_str ( "at any point in this process, please speak up!\n " ) ; 
12041204
12051205                if  issue. labels . iter ( ) . any ( |l| l == "T-lang" )  { 
    
 
   
 
     
   
   
          
     
  
    
     
 
    
      
     
 
     
    You can’t perform that action at this time.
  
 
    
  
     
    
      
        
     
 
       
      
     
   
 
    
    
  
 
  
 
     
    
0 commit comments