Skip to content

Commit de9627f

Browse files
NickeZemilio
authored andcommitted
Add references to issue
1 parent 93b9566 commit de9627f

File tree

4 files changed

+12
-0
lines changed

4 files changed

+12
-0
lines changed

bindgen-integration/build.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -301,6 +301,8 @@ fn setup_wrap_static_fns_test() {
301301
)
302302
.clang_arg("-DUSE_VA_HEADER");
303303

304+
// aarch64-linux has a bug, remove again when it is solved:
305+
// https://github.com/rust-lang/rust-bindgen/issues/3234
304306
#[cfg(all(target_arch = "aarch64", target_os = "linux"))]
305307
{
306308
builder = builder.clang_arg("-DDISABLE_VA");
@@ -323,6 +325,8 @@ fn setup_wrap_static_fns_test() {
323325
.arg(out_path.join("wrap_static_fns.c"))
324326
.arg("-DUSE_VA_HEADER");
325327

328+
// aarch64-linux has a bug, remove again when it is solved:
329+
// https://github.com/rust-lang/rust-bindgen/issues/3234
326330
#[cfg(all(target_arch = "aarch64", target_os = "linux"))]
327331
{
328332
command.arg("-DDISABLE_VA");

bindgen-integration/src/lib.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -335,6 +335,8 @@ fn test_wrap_static_fns() {
335335
extern_bindings::takes_qualified(&(&5 as *const _) as *const _);
336336
assert_eq!(5, tq);
337337

338+
// aarch64-linux has a bug, enable again when it is solved:
339+
// https://github.com/rust-lang/rust-bindgen/issues/3234
338340
#[cfg(not(all(target_arch = "aarch64", target_os = "linux")))]
339341
{
340342
let wv1 = extern_bindings::wrap_as_variadic_fn1_wrapped(0);

bindgen-tests/tests/headers/wrap-static-fns.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,8 @@ static inline int variadic(int x, ...) {
6060
return x;
6161
}
6262

63+
// aarch64-linux has a bug, remove ifdef when it is solved:
64+
// https://github.com/rust-lang/rust-bindgen/issues/3234
6365
#ifndef DISABLE_VA
6466

6567
static inline void no_extra_argument(__builtin_va_list va) {}

bindgen-tests/tests/tests.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -726,6 +726,8 @@ fn test_wrap_static_fns() {
726726
// TODO: If another such feature is added, convert this test into a more generic
727727
// test that looks at `tests/headers/generated` directory.
728728

729+
// aarch64-linux has a bug, remove custom source when it is solved:
730+
// https://github.com/rust-lang/rust-bindgen/issues/3234
729731
let wrap_static_fns_c_name =
730732
if cfg!(all(target_arch = "aarch64", target_os = "linux")) {
731733
"wrap_static_fns_aarch64_linux"
@@ -748,6 +750,8 @@ fn test_wrap_static_fns() {
748750
.wrap_static_fns_path(generated_path.display().to_string())
749751
.parse_callbacks(Box::new(parse_callbacks::WrapAsVariadicFn));
750752

753+
// aarch64-linux has a bug, remove when it is solved:
754+
// https://github.com/rust-lang/rust-bindgen/issues/3234
751755
#[cfg(all(target_arch = "aarch64", target_os = "linux"))]
752756
{
753757
builder = builder.clang_arg("-DDISABLE_VA");

0 commit comments

Comments
 (0)