Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the kind of item to ParseCallbacks::item_name #2736

Open
kupiakos opened this issue Jan 26, 2024 · 1 comment · May be fixed by #3129
Open

Pass the kind of item to ParseCallbacks::item_name #2736

kupiakos opened this issue Jan 26, 2024 · 1 comment · May be fixed by #3129
Labels
enhancement help wanted

Comments

@kupiakos
Copy link

Input C/C++ Header

enum long_prefix_to_remove_foo {
  BAR = 0
};

int long_prefix_to_remove_bar();

There is no way to implement ParseCallbacks::item_name that can follow different naming logic for these two items.

I propose that item_name be refactored to look more like generated_name_override, which passes in an info struct instead of solely a name.

Cc @vsukhoml
@emilio
Copy link
Contributor

emilio commented Feb 4, 2024

Seems sensible.

@twizmwazin twizmwazin linked a pull request Feb 13, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor item_name method to use ItemInfo struct twizmwazin/rust-bindgen
2 participants
@emilio @kupiakos