feat: Add deprecated_attributes_without_note

Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>

Author: hashcatHitman

CHANGELOG.md

@@ -6966,6 +6966,7 @@ Released 2018-09-13
 [`default_trait_access`]: https://rust-lang.github.io/rust-clippy/main/index.html#default_trait_access
 [`default_union_representation`]: https://rust-lang.github.io/rust-clippy/main/index.html#default_union_representation
 [`definition_in_module_root`]: https://rust-lang.github.io/rust-clippy/main/index.html#definition_in_module_root
+[`deprecated_attributes_without_note`]: https://rust-lang.github.io/rust-clippy/main/index.html#deprecated_attributes_without_note
 [`deprecated_attributes_without_since`]: https://rust-lang.github.io/rust-clippy/main/index.html#deprecated_attributes_without_since
 [`deprecated_cfg_attr`]: https://rust-lang.github.io/rust-clippy/main/index.html#deprecated_cfg_attr
 [`deprecated_clippy_cfg_attr`]: https://rust-lang.github.io/rust-clippy/main/index.html#deprecated_clippy_cfg_attr

clippy_lints/src/attrs/deprecated_attributes_without_note.rs

@@ -0,0 +1,49 @@
+use super::{Attribute, DEPRECATED_ATTRIBUTES_WITHOUT_NOTE};
+use clippy_utils::diagnostics::span_lint_and_sugg;
+use clippy_utils::source::snippet_with_applicability;
+use rustc_ast::{MetaItemInner, MetaItemKind};
+use rustc_errors::Applicability;
+use rustc_lint::EarlyContext;
+use rustc_span::sym;
+
+pub(super) fn check<'cx>(cx: &EarlyContext<'cx>, items: Option<&[MetaItemInner]>, attr: &'cx Attribute) {
+    if attr.value_span().is_some() {
+        return;
+    }
+
+    if let Some(items) = items {
+        for item_inner in items {
+            if let Some(item) = MetaItemInner::meta_item(item_inner)
+                && let MetaItemKind::NameValue(_) = &item.kind
+                && item.path == sym::note
+            {
+                return;
+            }
+        }
+    }
+
+    let mut applicability = Applicability::HasPlaceholders;
+    let suggestion = items.map_or_else(
+        || "#[deprecated(note = /* note */)]".to_owned(),
+        |items| {
+            let mut attr_with_fields = String::from("#[deprecated(");
+            for item in items {
+                let snippet = snippet_with_applicability(cx, item.span(), "_", &mut applicability);
+                attr_with_fields.push_str(&snippet);
+                attr_with_fields.push_str(", ");
+            }
+            attr_with_fields.push_str("note = /* note */)]");
+            attr_with_fields
+        },
+    );
+
+    span_lint_and_sugg(
+        cx,
+        DEPRECATED_ATTRIBUTES_WITHOUT_NOTE,
+        attr.span,
+        "`deprecated` attribute without note",
+        "add a note",
+        suggestion,
+        applicability,
+    );
+}

clippy_lints/src/attrs/mod.rs

@@ -1,6 +1,7 @@
 mod allow_attributes;
 mod allow_attributes_without_reason;
 mod blanket_clippy_restriction_lints;
+mod deprecated_attributes_without_note;
 mod deprecated_attributes_without_since;
 mod deprecated_cfg_attr;
 mod deprecated_semver;
@@ -105,6 +106,30 @@ declare_clippy_lint! {
     "enabling the complete restriction group"
 }
 
+declare_clippy_lint! {
+    /// ### What it does
+    /// Checks for attributes that deprecate items without a `note` field.
+    ///
+    /// ### Why restrict this?
+    /// This is typically used to provide an explanation about the deprecation
+    /// and preferred alternatives.
+    ///
+    /// ### Example
+    /// ```no_run
+    /// #[deprecated]
+    /// pub fn foo() { /* ... */ }
+    /// ```
+    /// Use instead:
+    /// ```no_run
+    /// #[deprecated(note = "foo was rarely used. Users should instead use bar")]
+    /// pub fn foo() { /* ... */ }
+    /// ```
+    #[clippy::version = "1.100.0"]
+    pub DEPRECATED_ATTRIBUTES_WITHOUT_NOTE,
+    restriction,
+    "ensures that all `deprecated` attributes have a `note` field"
+}
+
 declare_clippy_lint! {
     /// ### What it does
     /// Checks for attributes that deprecate items without a `since` field.
@@ -505,6 +530,7 @@ declare_clippy_lint! {
 }
 
 impl_lint_pass!(Attributes => [
+    DEPRECATED_ATTRIBUTES_WITHOUT_NOTE,
     DEPRECATED_ATTRIBUTES_WITHOUT_SINCE,
     INLINE_ALWAYS,
     REPR_PACKED_WITHOUT_ABI,
@@ -637,6 +663,7 @@ impl EarlyLintPass for PostExpansionEarlyAttributes {
             && !attr.span.in_external_macro(cx.sess().source_map())
             && !is_from_proc_macro(cx, attr)
         {
+            deprecated_attributes_without_note::check(cx, attr.meta_item_list().as_deref(), attr);
             deprecated_attributes_without_since::check(cx, attr.meta_item_list().as_deref(), attr);
         }
 

clippy_lints/src/declared_lints.rs

@@ -19,6 +19,7 @@ pub static LINTS: &[&::declare_clippy_lint::LintInfo] = &[
     crate::attrs::ALLOW_ATTRIBUTES_INFO,
     crate::attrs::ALLOW_ATTRIBUTES_WITHOUT_REASON_INFO,
     crate::attrs::BLANKET_CLIPPY_RESTRICTION_LINTS_INFO,
+    crate::attrs::DEPRECATED_ATTRIBUTES_WITHOUT_NOTE_INFO,
     crate::attrs::DEPRECATED_ATTRIBUTES_WITHOUT_SINCE_INFO,
     crate::attrs::DEPRECATED_CFG_ATTR_INFO,
     crate::attrs::DEPRECATED_CLIPPY_CFG_ATTR_INFO,

tests/ui/deprecated_attributes_without_note.rs

@@ -0,0 +1,49 @@
+//@aux-build:proc_macros.rs
+//@no-rustfix
+#![deny(clippy::deprecated_attributes_without_note)]
+
+extern crate proc_macros;
+use proc_macros::{external, with_span};
+
+fn main() {
+    // These should trigger the lint
+    #[deprecated]
+    //~^ deprecated_attributes_without_note
+    fn foo() {}
+
+    #[deprecated(since = "1.42.100")]
+    //~^ deprecated_attributes_without_note
+    fn quux() {}
+
+    // These should be fine
+    #[allow(deprecated)]
+    #[allow(dead_code, reason = "This should be allowed")]
+    #[expect(dead_code)]
+    #[warn(dyn_drop, reason = "Warnings can also have reasons")]
+    #[warn(redundant_lifetimes)]
+    #[deny(deref_nullptr)]
+    #[forbid(deref_nullptr)]
+    fn correct_attribute_only() {}
+
+    external! {
+        #[deprecated]
+        fn a() {}
+    }
+    with_span! {
+        span
+        #[deprecated]
+        fn b() {}
+    }
+
+    #[deprecated(since = "TBD", note = "use qux instead")]
+    fn baz() {}
+
+    #[deprecated(note = "use quux instead", since = "0.0.1")]
+    fn qux() {}
+
+    #[deprecated(note = "I don't feel like maintaining this anymore, sorry")]
+    fn bar() {}
+
+    #[deprecated = "probably a bad idea to use this"]
+    fn weird() {}
+}

tests/ui/deprecated_attributes_without_note.stderr

@@ -0,0 +1,20 @@
+error: `deprecated` attribute without note
+  --> tests/ui/deprecated_attributes_without_note.rs:10:5
+   |
+LL |     #[deprecated]
+   |     ^^^^^^^^^^^^^ help: add a note: `#[deprecated(note = /* note */)]`
+   |
+note: the lint level is defined here
+  --> tests/ui/deprecated_attributes_without_note.rs:3:9
+   |
+LL | #![deny(clippy::deprecated_attributes_without_note)]
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+error: `deprecated` attribute without note
+  --> tests/ui/deprecated_attributes_without_note.rs:14:5
+   |
+LL |     #[deprecated(since = "1.42.100")]
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a note: `#[deprecated(since = "1.42.100", note = /* note */)]`
+
+error: aborting due to 2 previous errors
+