"macabi" is not an "ABI" in the same sense as e.g. "gnueabihf"

[workingjubilee]

I know it has the literal characters "abi" in it but it's not an "ABI" in the sense of "gnueabihf", the HF and SF targets use actually-different calling conventions. It should probably have been a target_env.

Same story with the Apple "sim" targets.

[madsmtm]

So, I actually went and made a whole branch that adds target_env = "macabi"/target_env = "sim", but just before submitting that as a PR, I re-read the RFC and tracking issue, and it seems that target_abi was originally added for the purpose of Apple's sim/macabi targets.

@nvzqz, do you recall the motivation for not just using target_env?

[nvzqz]

I think it was just that "ABI" was in the target name, so having target_abi for specifying it felt appropriate at the time. Although thinking about it now, target_env probably expresses the semantics better.

[madsmtm]

Damn. Well, in that case, we could (and should) probably move forwards with this by setting both target_env and target_abi.

@rustbot claim

[workingjubilee]

Cool, let's do that then. I agree that we shouldn't break existing code that uses target_abi, but we may want actual ABI specifiers on a Darwin-based platform someday, so using target_env lets us actually switch to that.