use uX::from instead of _ as uX in non - const contexts #140435
+133
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
compiler-errors
requested changes
Apr 29, 2025
| func, | ||
| snippet, | ||
| span, | ||
| self.tcx.is_const_fn(def_id) |
There was a problem hiding this comment.
I don't believe this heuristic is complete. This leaves out const items and statics, for example.
There was a problem hiding this comment.
could you add some tests for statics, consts, and in const blocks?
There was a problem hiding this comment.
im not sure the heuristic is complete, but i added those tests and changed it a little.
compiler/rustc_mir_transform/src/check_unnecessary_transmutes.rs
Outdated
Show resolved
Hide resolved
bend-n
force-pushed
the
use_ux_from_instead_of_bool_as_ux_unnecessary_transmutes
branch
2 times, most recently
from
4050a31 to
5f5d1c6
Compare
bend-n
force-pushed
the
use_ux_from_instead_of_bool_as_ux_unnecessary_transmutes
branch
from
5f5d1c6 to
17737d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes
transmute(bool) -> integertointeger::fromas opposed tobool as integer.#136083 (comment)
@rustbot label L-unnecessary_transmutes