Skip to content

Subtree update cg gcc 2025 07 18 #144140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Jul 19, 2025

Conversation

GuillaumeGomez
Copy link
Member

cc @antoyo

r? ghost

sayantn and others added 30 commits June 15, 2025 04:33
…jubilee

Add SIMD funnel shift and round-to-even intrinsics

This PR adds 3 new SIMD intrinsics

 - `simd_funnel_shl` - funnel shift left
 - `simd_funnel_shr` - funnel shift right
 - `simd_round_ties_even` (vector version of `round_ties_even_fN`)

TODO (future PR): implement `simd_fsh{l,r}` in miri, cg_gcc and cg_clif (it is surprisingly hard to implement without branches, the common tricks that rotate uses doesn't work because we have 2 elements now. e.g, the `-n&31` trick used by cg_gcc to implement rotate doesn't work with this because then `fshl(a, b, 0)` will be `a | b`)

[#t-compiler > More SIMD intrinsics](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/More.20SIMD.20intrinsics/with/522130286)

`@rustbot` label T-compiler T-libs A-intrinsics F-core_intrinsics
r? `@workingjubilee`
…_2025-06-30, r=GuillaumeGomez

GCC backend subtree update

cc `@antoyo`

r? ghost
give Pointer::into_parts a more scary name and offer a safer alternative

`into_parts` is a bit too innocent of a name for a somewhat subtle operation.
r? `@oli-obk`
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#143019 (Ensure -V --verbose processes both codegen_backend and codegen-backend)
 - rust-lang#143140 (give Pointer::into_parts a more scary name and offer a safer alternative)
 - rust-lang#143175 (Make combining LLD with external LLVM config a hard error)
 - rust-lang#143180 (Use `tracing-forest` instead of `tracing-tree` for bootstrap tracing)
 - rust-lang#143223 (Improve macro stats printing)
 - rust-lang#143228 (Handle build scripts better in `-Zmacro-stats` output.)
 - rust-lang#143229 ([COMPILETEST-UNTANGLE 1/N] Move some some early config checks to the lib and move the compiletest binary)
 - rust-lang#143246 (Subtree update of `rust-analyzer`)
 - rust-lang#143248 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
…et-triple-env-var

Remove OVERWRITE_TARGET_TRIPLE env var now that config.sh is gone
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 18, 2025

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@GuillaumeGomez
Copy link
Member Author

@bors r+ p=1 rollup=never

@bors
Copy link
Collaborator

bors commented Jul 18, 2025

📌 Commit 66017df has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2025
@@ -198,10 +198,24 @@ fn main() {
assert_eq!(intrinsics::align_of::<u16>() as u8, 2);
assert_eq!(intrinsics::align_of_val(&a) as u8, intrinsics::align_of::<&str>() as u8);

<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you missed those conflict delimiters.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof. Indeed. And of course, this test is not check when running x.py yet. ^^'

@GuillaumeGomez
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 18, 2025
@GuillaumeGomez
Copy link
Member Author

@bors r+ p=1 rollup=never

@bors
Copy link
Collaborator

bors commented Jul 18, 2025

📌 Commit f16474f has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2025
@bors
Copy link
Collaborator

bors commented Jul 18, 2025

⌛ Testing commit f16474f with merge ebd8557...

@bors
Copy link
Collaborator

bors commented Jul 19, 2025

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing ebd8557 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 19, 2025
@bors bors merged commit ebd8557 into rust-lang:master Jul 19, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 19, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8f08b3a (parent) -> ebd8557 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ebd8557637b33cc09b6ee8273f3154d5d3af6a15 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 5415.0s -> 3567.3s (-34.1%)
  2. x86_64-rust-for-linux: 3206.3s -> 2523.4s (-21.3%)
  3. pr-check-2: 2661.6s -> 2123.5s (-20.2%)
  4. dist-apple-various: 9106.0s -> 7456.6s (-18.1%)
  5. dist-aarch64-apple: 4757.3s -> 5602.8s (17.8%)
  6. aarch64-apple: 4012.6s -> 4684.0s (16.7%)
  7. dist-s390x-linux: 4964.0s -> 5762.3s (16.1%)
  8. arm-android: 6746.5s -> 5730.1s (-15.1%)
  9. pr-check-1: 1706.1s -> 1509.8s (-11.5%)
  10. tidy: 72.7s -> 64.7s (-11.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ebd8557): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.2% [0.0%, 0.5%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -6.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-6.0% [-6.0%, -6.0%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.311s -> 465.449s (0.03%)
Artifact size: 374.60 MiB -> 374.66 MiB (0.02%)

@GuillaumeGomez GuillaumeGomez deleted the subtree-update_cg_gcc_2025-07-18 branch July 19, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants