Rollup of 6 pull requests #144231

GuillaumeGomez · 2025-07-20T21:28:42Z

Successful merges:

gpu offload host code generation #142097 (gpu offload host code generation)
Miri: non-deterministic floating point operations in foreign_items #143906 (Miri: non-deterministic floating point operations in foreign_items)
tests: Skip supported-crate-types test on musl hosts #144144 (tests: Skip supported-crate-types test on musl hosts)
Debug impls for DropElaborators #144162 (Debug impls for DropElaborators)
Add non-regression test for #144168 #144189 (Add non-regression test for zerocopy-0.8.25 no longer builds on nightly #144168)
Don't consider unstable fields always-inhabited #144216 (Don't consider unstable fields always-inhabited)

r? @ghost
@rustbot modify labels: rollup

This test depends on the target-specific behavior of crt-static for musl targets. However, running the testsuite on a musl host requires setting `crt-static` to `false`, as it wouldn't otherwise be possible to build rustc. This in turn will enable `-Ctarget-feature=-crt-static` for all tests, mismatching the expected `+crt-static` for the musl target tested in this testcase. Since this test specifically tests the default value of `crt-static` for the musl target, ignoring it entirely makes more sense than manually setting `-Ctarget-feature=+crt-static` here, but both would be valid approaches. Signed-off-by: Jens Reidel <[email protected]>

…ost) code generation

This reverts the hack in rust-lang#133889 now that `Pin`'s field is no longer public.

gpu offload host code generation r? ghost This will generate most of the host side code to use llvm's offload feature. The first PR will only handle automatic mem-transfers to and from the device. So if a user calls a kernel, we will copy inputs back and forth, but we won't do the actual kernel launch. Before merging, we will use LLVM's Info infrastructure to verify that the memcopies match what openmp offloa generates in C++. `LIBOMPTARGET_INFO=-1 ./my_rust_binary` should print that a memcpy to and later from the device is happening. A follow-up PR will generate the actual device-side kernel which will then do computations on the GPU. A third PR will implement manual host2device and device2host functionality, but the goal is to minimize cases where a user has to overwrite our default handling due to performance issues. I'm trying to get a full MVP out first, so this just recognizes GPU functions based on magic names. The final frontend will obviously move this over to use proper macros, like I'm already doing it for the autodiff work. This work will also be compatible with std::autodiff, so one can differentiate GPU kernels. Tracking: - rust-lang#131513

…-foreign-items, r=RalfJung Miri: non-deterministic floating point operations in `foreign_items` Part of [rust-lang/miri/rust-lang#3555](rust-lang/miri#3555 (comment)), this pr does the `foreign_items` work. Some things have changed since rust-lang#138062 and rust-lang#142514. I moved the "helpers" used for creating fixed outputs and clamping operations to their defined ranges to `helpers.rs`. These are now also extended to handle the floating-point operations in `foreign_items`. Tests in `miri/tests/float.rs` were changed/added. Failing tests in `std` were extracted, run under miri with `-Zmiri-many-seeds=0..1000` and changed accordingly. Double checked with `-Zmiri-many-seeds`. I noticed that the C standard doesn't specify the output ranges for all of its mathematical operations; it just specifies them as: ``` Returns The sinh functions return sinh x. ``` So I used [Wolfram|Alpha](https://www.wolframalpha.com/).

…=compiler-errors tests: Skip supported-crate-types test on musl hosts This test depends on the target-specific default of crt-static for musl targets. However, running the testsuite on a musl host requires setting `crt-static` to `false`, as it wouldn't otherwise be possible to build rustc. This in turn will enable `-Ctarget-feature=-crt-static` for all tests, mismatching the expected `+crt-static` for the musl target tested in this testcase. Since this test specifically tests the default value of `crt-static` for the musl target, ignoring it entirely makes more sense than manually setting `-Ctarget-feature=+crt-static` here, but both would be valid approaches.

…_impls, r=compiler-errors Debug impls for DropElaborators It's a little weird that these just have a completely empty Debug impl. Now they're `ElaborateDropsCtxt { .. }` and `DropShimElaborator { .. }`.

Add non-regression test for rust-lang#144168 This is a non-regression test for issue rust-lang#144168, reduced from `zerocopy`, to go with rust-lang#144172 since it had no test yet, and we didn't want to delay it from landing. Closes rust-lang#144168 I've checked that the test does fail without rust-lang#144172.

…ler-errors Don't consider unstable fields always-inhabited This reverts the hack in rust-lang#133889 now that `Pin`'s field is no longer public. Fixes rust-lang#143468. r? ``@compiler-errors``

GuillaumeGomez · 2025-07-20T21:28:56Z

@bors r+ p=5 rollup=never

bors · 2025-07-20T21:28:58Z

📌 Commit f2f5c89 has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors · 2025-07-21T00:53:10Z

⌛ Testing commit f2f5c89 with merge 7b82649...

Rollup of 6 pull requests Successful merges: - #142097 (gpu offload host code generation) - #143906 (Miri: non-deterministic floating point operations in `foreign_items`) - #144144 (tests: Skip supported-crate-types test on musl hosts) - #144162 (Debug impls for DropElaborators) - #144189 (Add non-regression test for #144168) - #144216 (Don't consider unstable fields always-inhabited) r? `@ghost` `@rustbot` modify labels: rollup

rust-log-analyzer · 2025-07-21T02:30:01Z

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- num::flt2dec::strategy::dragon::shortest_sanity_test stdout ----

thread 'num::flt2dec::strategy::dragon::shortest_sanity_test' panicked at library/coretests/tests/num/flt2dec/mod.rs:443:5:
shortest mismatch for v=ldexp_f64(1.0, 64): actual ("18446744073709535", 20), expected ("18446744073709552", 20)

---- num::flt2dec::strategy::grisu::shortest_sanity_test stdout ----

thread 'num::flt2dec::strategy::grisu::shortest_sanity_test' panicked at library/coretests/tests/num/flt2dec/mod.rs:443:5:
shortest mismatch for v=ldexp_f64(1.0, 64): actual ("18446744073709543", 20), expected ("18446744073709552", 20)


failures:
    num::flt2dec::strategy::dragon::shortest_sanity_test
    num::flt2dec::strategy::grisu::shortest_sanity_test

test result: FAILED. 2090 passed; 2 failed; 9 ignored; 0 measured; 0 filtered out; finished in 553.58s

error: test failed, to rerun pass `-p coretests --test coretests`
Build completed unsuccessfully in 0:28:05
make: *** [Makefile:53: check-aux] Error 1
  local time: Mon Jul 21 02:29:50 UTC 2025
  network time: Mon, 21 Jul 2025 02:29:50 GMT
##[error]Process completed with exit code 2.
Post job cleanup.

bors · 2025-07-21T02:30:51Z

💔 Test failed - checks-actions

jieyouxu · 2025-07-21T02:46:25Z

Probably #143906.
@bors r-

Gelbpunkt and others added 21 commits July 18, 2025 19:05

enzyme submodule update

3fb1af3

make more builder functions generic

42d6b0d

add -Zoffload=Enable flag behind -Zunstable-options, to enable gpu (h…

6340164

…ost) code generation

add various wrappers for gpu code generation

5958ebe

gpu host code generation

4a1a5a4

add gpu offload codegen host side test

e2ab312

add unstable-books doc for offload

c068599

debug impls for drop elaborators

2a03750

Move float non determinism helpers to math.rs

5a5027a

Implement nondet behaviour and change/add tests.

df62935

Change stdlib float tests to account for miri nondet floats.

8978073

add non-regression test for issue 144168

8f77d54

Add test

e9fb744

Don't consider unstable fields always-inhabited

3567ab1

This reverts the hack in rust-lang#133889 now that `Pin`'s field is no longer public.

Rollup merge of rust-lang#144162 - beepster4096:drop_elaborator_debug…

8834ffe

…_impls, r=compiler-errors Debug impls for DropElaborators It's a little weird that these just have a completely empty Debug impl. Now they're `ElaborateDropsCtxt { .. }` and `DropShimElaborator { .. }`.

Rollup merge of rust-lang#144216 - Nadrieril:revert-pin-hack, r=compi…

f2f5c89

…ler-errors Don't consider unstable fields always-inhabited This reverts the hack in rust-lang#133889 now that `Pin`'s field is no longer public. Fixes rust-lang#143468. r? ``@compiler-errors``

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2025

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 20, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 21, 2025

jieyouxu mentioned this pull request Jul 21, 2025

Miri: non-deterministic floating point operations in foreign_items #143906

Open

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2025

jieyouxu closed this Jul 21, 2025

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 21, 2025

GuillaumeGomez deleted the rollup-hjxqi9q branch July 21, 2025 08:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 6 pull requests #144231

Rollup of 6 pull requests #144231

Uh oh!

GuillaumeGomez commented Jul 20, 2025 •

edited by rustbot

Loading

Uh oh!

GuillaumeGomez commented Jul 20, 2025

Uh oh!

bors commented Jul 20, 2025

Uh oh!

bors commented Jul 21, 2025

Uh oh!

rust-log-analyzer commented Jul 21, 2025

Uh oh!

bors commented Jul 21, 2025

Uh oh!

jieyouxu commented Jul 21, 2025

Uh oh!

Uh oh!

Rollup of 6 pull requests #144231

Rollup of 6 pull requests #144231

Uh oh!

Conversation

GuillaumeGomez commented Jul 20, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuillaumeGomez commented Jul 20, 2025

Uh oh!

bors commented Jul 20, 2025

Uh oh!

bors commented Jul 21, 2025

Uh oh!

rust-log-analyzer commented Jul 21, 2025

Uh oh!

bors commented Jul 21, 2025

Uh oh!

jieyouxu commented Jul 21, 2025

Uh oh!

Uh oh!

GuillaumeGomez commented Jul 20, 2025 •

edited by rustbot

Loading