PR feedback; use Duration type

Author: Jamesbarford

database/src/lib.rs

@@ -814,7 +814,7 @@ pub enum BenchmarkRequestStatus {
     InProgress,
     Completed {
         completed_at: DateTime<Utc>,
-        duration_ms: u32,
+        duration: Duration,
     },
 }
 
@@ -846,9 +846,9 @@ impl BenchmarkRequestStatus {
                 completed_at: completion_date.ok_or_else(|| {
                     anyhow!("No completion date for a completed BenchmarkRequestStatus")
                 })?,
-                duration_ms: duration_ms.ok_or_else(|| {
+                duration: Duration::from_millis(duration_ms.ok_or_else(|| {
                     anyhow!("No completion duration for a completed BenchmarkRequestStatus")
-                })? as u32,
+                })? as u64),
             }),
             _ => Err(anyhow!("Unknown BenchmarkRequestStatus `{text}`")),
         }

database/src/pool.rs

@@ -973,6 +973,9 @@ mod tests {
 
             assert_eq!(job.request_tag(), benchmark_request.tag().unwrap());
 
+            /* Make the job take some amount of time */
+            std::thread::sleep(Duration::from_millis(1000));
+
             /* Mark the job as complete */
             db.mark_benchmark_job_as_completed(job.id(), BenchmarkJobConclusion::Success)
                 .await
@@ -994,10 +997,10 @@ mod tests {
                 req.status(),
                 BenchmarkRequestStatus::Completed { .. }
             ));
-            let BenchmarkRequestStatus::Completed { duration_ms, .. } = req.status() else {
+            let BenchmarkRequestStatus::Completed { duration, .. } = req.status() else {
                 unreachable!();
             };
-            assert!(duration_ms >= 1);
+            assert!(duration >= Duration::from_millis(1000));
 
             let completed_index = db.load_benchmark_request_index().await.unwrap();
             assert!(completed_index.contains_tag("sha-1"));