Skip to content

Commit 5ae6a0c

Browse files
Mark-SimulacrumMark-Simulacrum
committed
Add triage for this week
1 parent b2f6179 commit 5ae6a0c

File tree

1 file changed

+165
-0
lines changed

1 file changed

+165
-0
lines changed

‎triage/2025/2025-09-28.md‎

Lines changed: 165 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,165 @@
1+
# 2025-09-29 Triage Log
2+
3+
A relatively quiet week. Most of the improvements are to doc builds, driven by
4+
continued packing of the search index in rustdoc-search: stringdex update with
5+
more packing [#147002](https://github.com/rust-lang/rust/pull/147002) and
6+
simplifications to doc(cfg) in Implement RFC 3631: add rustdoc doc_cfg features
7+
[#138907](https://github.com/rust-lang/rust/pull/138907).
8+
9+
Triage done by **@simulacrum**.
10+
Revision range: [ce4beebe..8d72d3e1](https://perf.rust-lang.org/?start=ce4beebecb77821734079cff47d8af08f9f27f11&end=8d72d3e1e96f58ca10059a6bb6e8aecba4a0e9cd&absolute=false&stat=instructions%3Au)
11+
12+
**Summary**:
13+
14+
| (instructions:u) | mean | range | count |
15+
|:----------------------------------:|:-----:|:--------------:|:-----:|
16+
| Regressions ❌ <br /> (primary) | 0.3% | [0.1%, 1.6%] | 19 |
17+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.1%, 2.7%] | 39 |
18+
| Improvements ✅ <br /> (primary) | -0.9% | [-8.5%, -0.1%] | 66 |
19+
| Improvements ✅ <br /> (secondary) | -0.4% | [-3.2%, -0.1%] | 80 |
20+
| All ❌✅ (primary) | -0.6% | [-8.5%, 1.6%] | 85 |
21+
22+
1 Regressions, 6 Improvements, 4 Mixed; 2 of them in rollups
23+
29 artifact comparisons made in total
24+
25+
#### Regressions
26+
27+
remove incorrect fast path [#146919](https://github.com/rust-lang/rust/pull/146919) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7ac0330c6d684d86d6f86fabe601a3defdc3b234&end=b733736ea2feb7798c99cbb9a769bce74be108df&stat=instructions:u)
28+
29+
| (instructions:u) | mean | range | count |
30+
|:----------------------------------:|:----:|:------------:|:-----:|
31+
| Regressions ❌ <br /> (primary) | - | - | 0 |
32+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.1%, 0.8%] | 15 |
33+
| Improvements ✅ <br /> (primary) | - | - | 0 |
34+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
35+
| All ❌✅ (primary) | - | - | 0 |
36+
37+
Necessary regression for correctness.
38+
39+
#### Improvements
40+
41+
Avoid invalidating CFG caches from MirPatch::apply. [#146697](https://github.com/rust-lang/rust/pull/146697) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6f34f4ee074ce0affc7bbf4e2c835f66cd576f13&end=eabf390b4ceeb34db9f37e97f435134abbcdea92&stat=instructions:u)
42+
43+
| (instructions:u) | mean | range | count |
44+
|:----------------------------------:|:-----:|:--------------:|:-----:|
45+
| Regressions ❌ <br /> (primary) | - | - | 0 |
46+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
47+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.1%] | 3 |
48+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.4%, -0.1%] | 10 |
49+
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.1%] | 3 |
50+
51+
52+
support opaque types in method selection [#146885](https://github.com/rust-lang/rust/pull/146885) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a8858111044a9391ac7558f969d3bf62ef43222d&end=54a8a1db604e4caff93e26e167ad4a6fde9f0681&stat=instructions:u)
53+
54+
| (instructions:u) | mean | range | count |
55+
|:----------------------------------:|:-----:|:--------------:|:-----:|
56+
| Regressions ❌ <br /> (primary) | - | - | 0 |
57+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
58+
| Improvements ✅ <br /> (primary) | - | - | 0 |
59+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.2%, -0.1%] | 10 |
60+
| All ❌✅ (primary) | - | - | 0 |
61+
62+
63+
Remove most `#[track_caller]` from allocating Vec methods [#147042](https://github.com/rust-lang/rust/pull/147042) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=848e6746fe03dfd703075c5077312b63877d51d6&end=c7f6aa2869acdbf014d094c6e427e554e160b6db&stat=instructions:u)
64+
65+
| (instructions:u) | mean | range | count |
66+
|:----------------------------------:|:-----:|:--------------:|:-----:|
67+
| Regressions ❌ <br /> (primary) | 0.9% | [0.9%, 0.9%] | 1 |
68+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.4%] | 4 |
69+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.7%, -0.1%] | 37 |
70+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.5%, -0.0%] | 26 |
71+
| All ❌✅ (primary) | -0.3% | [-0.7%, 0.9%] | 38 |
72+
73+
74+
rustdoc-search: use the same ID for entry and path to same item [#147045](https://github.com/rust-lang/rust/pull/147045) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c7f6aa2869acdbf014d094c6e427e554e160b6db&end=4ffeda10e10d4fa0c8edbd0dd9642d8ae7d3e66e&stat=instructions:u)
75+
76+
| (instructions:u) | mean | range | count |
77+
|:----------------------------------:|:-----:|:--------------:|:-----:|
78+
| Regressions ❌ <br /> (primary) | - | - | 0 |
79+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
80+
| Improvements ✅ <br /> (primary) | -0.1% | [-0.2%, -0.1%] | 3 |
81+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.4%, -0.1%] | 2 |
82+
| All ❌✅ (primary) | -0.1% | [-0.2%, -0.1%] | 3 |
83+
84+
JumpThreading: Avoid computing dominators to identify loop headers. [#146829](https://github.com/rust-lang/rust/pull/146829) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=959b450747f81e720be3a829665dd30e553e7fd7&end=ade84871f718ea20a6460d28e82290353b4bf3d2&stat=instructions:u)
85+
86+
| (instructions:u) | mean | range | count |
87+
|:----------------------------------:|:-----:|:--------------:|:-----:|
88+
| Regressions ❌ <br /> (primary) | - | - | 0 |
89+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.3%] | 1 |
90+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.3%, -0.2%] | 2 |
91+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.3%, -0.2%] | 2 |
92+
| All ❌✅ (primary) | -0.2% | [-0.3%, -0.2%] | 2 |
93+
94+
One regression is bimodality.
95+
96+
rustdoc-search: stringdex update with more packing [#147002](https://github.com/rust-lang/rust/pull/147002) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a00a5159cfac23e9b1551566cf71ff31edc1f11b&end=8d72d3e1e96f58ca10059a6bb6e8aecba4a0e9cd&stat=instructions:u)
97+
98+
| (instructions:u) | mean | range | count |
99+
|:----------------------------------:|:-----:|:--------------:|:-----:|
100+
| Regressions ❌ <br /> (primary) | - | - | 0 |
101+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.3%] | 1 |
102+
| Improvements ✅ <br /> (primary) | -1.9% | [-5.8%, -0.2%] | 6 |
103+
| Improvements ✅ <br /> (secondary) | -1.2% | [-3.1%, -0.1%] | 3 |
104+
| All ❌✅ (primary) | -1.9% | [-5.8%, -0.2%] | 6 |
105+
106+
One regression is bimodality.
107+
108+
#### Mixed
109+
110+
Rollup of 8 pull requests [#147037](https://github.com/rust-lang/rust/pull/147037) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=eabf390b4ceeb34db9f37e97f435134abbcdea92&end=7ac0330c6d684d86d6f86fabe601a3defdc3b234&stat=instructions:u)
111+
112+
| (instructions:u) | mean | range | count |
113+
|:----------------------------------:|:-----:|:--------------:|:-----:|
114+
| Regressions ❌ <br /> (primary) | 0.1% | [0.1%, 0.1%] | 2 |
115+
| Regressions ❌ <br /> (secondary) | 0.1% | [0.1%, 0.1%] | 2 |
116+
| Improvements ✅ <br /> (primary) | -1.0% | [-1.1%, -0.9%] | 2 |
117+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
118+
| All ❌✅ (primary) | -0.4% | [-1.1%, 0.1%] | 4 |
119+
120+
Several rustdoc changes, including what looks like net-new feature work. I
121+
don't think it's worth digging deeper into the relatively small, relatively
122+
few-benchmark-affecting doc regressions here.
123+
124+
Extended temporary argument to format_args!() in all cases [#145882](https://github.com/rust-lang/rust/pull/145882) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b733736ea2feb7798c99cbb9a769bce74be108df&end=40ace17fc3891155bad26a50d60a9ab07b83bf8e&stat=instructions:u)
125+
126+
| (instructions:u) | mean | range | count |
127+
|:----------------------------------:|:-----:|:--------------:|:-----:|
128+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 0.8%] | 15 |
129+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.0%, 2.9%] | 19 |
130+
| Improvements ✅ <br /> (primary) | -1.0% | [-1.7%, -0.4%] | 5 |
131+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.2%, -0.1%] | 3 |
132+
| All ❌✅ (primary) | 0.0% | [-1.7%, 0.8%] | 20 |
133+
134+
Correctness fix, likely affects a bunch of code across the compiler and
135+
probably not worth digging deeper.
136+
137+
Rollup of 10 pull requests [#147074](https://github.com/rust-lang/rust/pull/147074) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=54a8a1db604e4caff93e26e167ad4a6fde9f0681&end=e1318422222101423fdbbe0f375109c3b40f75bc&stat=instructions:u)
138+
139+
| (instructions:u) | mean | range | count |
140+
|:----------------------------------:|:-----:|:--------------:|:-----:|
141+
| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.3%] | 4 |
142+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.1%, 0.5%] | 3 |
143+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.3%] | 1 |
144+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
145+
| All ❌✅ (primary) | 0.1% | [-0.3%, 0.3%] | 5 |
146+
147+
Regression in a few benchmarks that seem to have slowly regressed over several
148+
commits.... Mostly limited to incremental scenarios, but I'm not seeing
149+
anything obvious in this PR related to incremental -- given it's a rollup
150+
doesn't seem worth digging further. Cachegrind results show regressions mostly
151+
in fluent_syntax/bundle loading, which doesn't clearly map to any of the
152+
contained PRs.
153+
154+
Implement RFC 3631: add rustdoc doc_cfg features [#138907](https://github.com/rust-lang/rust/pull/138907) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ade84871f718ea20a6460d28e82290353b4bf3d2&end=c0ee51f07d271f7cf3227c60a2c59aa18c959192&stat=instructions:u)
155+
156+
| (instructions:u) | mean | range | count |
157+
|:----------------------------------:|:-----:|:--------------:|:-----:|
158+
| Regressions ❌ <br /> (primary) | 0.3% | [0.1%, 0.6%] | 6 |
159+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.1%, 0.6%] | 17 |
160+
| Improvements ✅ <br /> (primary) | -1.6% | [-4.2%, -0.3%] | 12 |
161+
| Improvements ✅ <br /> (secondary) | -0.4% | [-1.0%, -0.1%] | 4 |
162+
| All ❌✅ (primary) | -1.0% | [-4.2%, 0.6%] | 18 |
163+
164+
Mixed results, but since it's a new feature and an overall improvement seems
165+
acceptable.

0 commit comments

Comments
 (0)