Skip to content

triage report seems to forget last commit in summary section #2493

Description

@panstromek

Encountered in #2492. When I generated the initial report, I used this command:

curl "https://perf.rust-lang.org/perf/triage?start=7dc2c162b9c197aaa76a6f9e7534569537830a01" > 2026-07-06.md

i.e. no end commit, and the last commit on main was 3c00c96d3af4d5b5e101e56cc161a608b21366ee at the time.

The triage report contains an entry for 3c00c96d3af4d5b5e101e56cc161a608b21366ee (the last commit) in Improvements section:


Use `LowerAvailableDepth::No` for normalizes-to goal itself instead of its nested goals [#158705](https://github.com/rust-lang/rust/pull/158705) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=3659db0d3e2cd634c766fcda79ed118eca31a9fd&end=3c00c96d3af4d5b5e101e56cc161a608b21366ee&stat=instructions:u)

| (instructions:u)                   | mean   | range            | count |
|:----------------------------------:|:------:|:----------------:|:-----:|
| Regressions ❌ <br /> (primary)    | -      | -                | 0     |
| Regressions ❌ <br /> (secondary)  | -      | -                | 0     |
| Improvements ✅ <br /> (primary)   | -      | -                | 0     |
| Improvements ✅ <br /> (secondary) | -37.4% | [-37.7%, -37.2%] | 3     |
| All ❌✅ (primary)                 | -      | -                | 0     |


The summary report looks like this, notably it doesn't include the regression fix in the table (that's how I noticed):

Revision range: [7dc2c162..3659db0d](https://perf.rust-lang.org/?start=7dc2c162b9c197aaa76a6f9e7534569537830a01&end=3659db0d3e2cd634c766fcda79ed118eca31a9fd&absolute=false&stat=instructions%3Au)

**Summary**:

| (instructions:u)                   | mean   | range           | count |
|:----------------------------------:|:------:|:---------------:|:-----:|
| Regressions ❌ <br /> (primary)    | 0.2%   | [0.2%, 0.2%]    | 3     |
| Regressions ❌ <br /> (secondary)  | 162.1% | [0.2%, 1116.3%] | 20    |
| Improvements ✅ <br /> (primary)   | -1.4%  | [-8.4%, -0.1%]  | 7     |
| Improvements ✅ <br /> (secondary) | -1.1%  | [-8.4%, -0.1%]  | 11    |
| All ❌✅ (primary)                 | -0.9%  | [-8.4%, 0.2%]   | 10    |

The end commit is 3659db0d3e2cd634c766fcda79ed118eca31a9fd, which is a parent of the regression fix (3c00c96d3af4d5b5e101e56cc161a608b21366ee).


Few more commands

I tried to run a few more commands to test:

Next week triage command (if the next person copies the end commit from my summary)

curl "https://perf.rust-lang.org/perf/triage?start=3659db0d3e2cd634c766fcda79ed118eca31a9fd" > test-next.md

Output:

Revision range: [3659db0d..3659db0d](https://perf.rust-lang.org/?start=3659db0d3e2cd634c766fcda79ed118eca31a9fd&end=3659db0d3e2cd634c766fcda79ed118eca31a9fd&absolute=false&stat=instructions%3Au)

Includes 3c00c96d3af4d5b5e101e56cc161a608b21366ee in the Improvements section again (which reproduces #1599, I believe). Otherwise empty


Recreating the current report with explicit end commit:

curl "https://perf.rust-lang.org/perf/triage?start=7dc2c162b9c197aaa76a6f9e7534569537830a01&end=3659db0d3e2cd634c766fcda79ed118eca31a9fd" > test-current.md

Output:

Revision range: [7dc2c162..1c02d902](https://perf.rust-lang.org/?start=7dc2c162b9c197aaa76a6f9e7534569537830a01&end=1c02d9026c9da54ef3323436f0ed0f8dd091d128&absolute=false&stat=instructions%3Au)

Notably, the end commit is different - it's 1c02d9, which is a parent of the desired end commit from the url.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions