Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"public" is a keyword and causes errors #14

Open
yberkholz opened this issue Sep 20, 2012 · 2 comments
Open

"public" is a keyword and causes errors #14

yberkholz opened this issue Sep 20, 2012 · 2 comments

Comments

@yberkholz
Copy link

publicis a keyword - therefor it causes error when using a compressor e.g. yuicompressor.

Solution:
Enclose in doublequotes:

    pluginFns    = {
        "public": {

and access using pluginFns["public"] instead of pluginFns.public.

Alternatively rename it.

@rwaldron
Copy link
Owner

Property keys are IdentifierName and IdentifierNames are allowed to be ReservedWords, however Identifiers are not. Platforms that throw are incorrectly implemented, but you're right here—this will throw in oldIE and Safari 5.x

Can you make a PR?

@yberkholz
Copy link
Author

PR done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants