fixed stream responders lifetimes #2944
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the stream responders have a very restricted lifetime which doesn't allow using them, and this lifetime restriction doesn't appear on the other responder implementations.
A short example of the current implementation's usage:
The error generated is the following:
The generated code from the derive shows that the
rocket::response::Resultlifetime is the same as therocket::request::Requestand can't live longer than that.Fixing the lifetimes (in the same pattern as what's been done on e.g.
&str) solves the issue.i have tested the fix on
ReaderStreamas it's the one i'm using in my project and applied the same fix over to the other stream implementations but as i don't understand them as much i didn't properly test them on this.Note: My project's rocket version is
0.5.1, that's where a friend and i initially found the issue leading to this fix.