Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contradict #422

Open
jovenbarola opened this issue Mar 24, 2023 · 1 comment
Open

Contradict #422

jovenbarola opened this issue Mar 24, 2023 · 1 comment

Comments

@jovenbarola
Copy link

Sorry, but it seems some rules here are contradict on what its currently your being practiced

Example of what I meant is "Don't leave commented out code in your codebase", the previous rule mentioned it needs to have comment if its business logic,

And also need to clear if this applicable to different language.. as i noticed some of your C++ code still use comments

Anyway Although this is 7years old repo, I think people need to atleast know contradict is, and this new issue ticket atleast help them know what to look and see to be consistent

@BrianH824
Copy link

Don't comment out code does not mean don't write comments. Commented out code is code that was previously in use, that is no longer being used, and instead of being deleted has been prefixed with '//' (In JavaScript).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants