Skip to content

Commit 702b704

Browse files
committed
Added tests from reported issues about Generics
1 parent b2e9cfd commit 702b704

File tree

3 files changed

+19
-0
lines changed

3 files changed

+19
-0
lines changed

testdata/sqlx_examples/correct_generics.go

Whitespace-only changes.
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
# github.com/ryanrolds/sqlclosecheck/testdata/sqlx_examples
2+
testdata/sqlx_examples/failure_generics.go:6:21: Rows/Stmt was not closed
3+
testdata/sqlx_examples/failure_generics.go:13:21: Rows/Stmt was not closed
24
testdata/sqlx_examples/missing_close.go:10:24: Rows/Stmt was not closed
35
testdata/sqlx_examples/non_defer_close.go:30:12: Close should use defer
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
package sqlx_examples
2+
3+
import "database/sql"
4+
5+
func SqlCloseCheck(db *sql.DB, a int) {
6+
rows, _ := db.Query("select id from tb") // <- detected OK
7+
for rows.Next() {
8+
9+
}
10+
}
11+
12+
func SqlCloseCheckG[T ~int64](db *sql.DB, a T) {
13+
rows, _ := db.Query("select id from tb") // <- not detected KO
14+
for rows.Next() {
15+
16+
}
17+
}

0 commit comments

Comments
 (0)