Skip to content

Commit f6f1512

Browse files
rydmikerydmike
committed
Version 8.1.1 FIX button icon color issue
1 parent 5e74aa3 commit f6f1512

File tree

17 files changed

+631
-162
lines changed

17 files changed

+631
-162
lines changed

‎CHANGELOG.md

+20
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,26 @@
22

33
All changes to the **FlexColorScheme** (FCS) package are documented here.
44

5+
## 8.1.1
6+
7+
**Feb 15, 2025**
8+
9+
**NOTE**
10+
11+
This fix release only contains a critical **Flutter BUG** workaround solution for users of Flutter versions 3.27.0 to 3.27.4 and 3.29.0.
12+
13+
This release does not contain any support for new theming features released in Flutter 3.29.0, nor does it address theming properties that were deprecated in Flutter 3.29.0. **FlexColorScheme** v8.1.1 and v8.1.0, sans the useful workaround released here, are verified to work with Flutter v3.29 as is. A later **FlexColorScheme** release v8.2.0, will add new theming features and also remove the theming properties that were deprecated in Flutter 3.29.0. Removing them has no impact on FlexColorScheme produced Material-3 themes in Flutter 3.29. Removing and fixing all the deprecations will break things in Flutter 3.27 versions, since some of their replacements do not exist in Flutter 3.27. The issue workaround and fix added here is intended to also support the issue in Flutter 3.27 versions, not only in Flutter 3.29, thus we cannot address the 3.29 deprecations in this release.
14+
15+
### Package
16+
17+
**FIX**
18+
19+
* In Flutter **3.27.0** to at least Flutter **3.29.0** the `iconColor` on buttons `ElevatedButton`, `FilledButton`, `OutlinedButton`, `TextButton` and `SegmentedButton` no longer default to `foregroundColor` when `iconColor` is not defined. This is caused by a **BREAKING REGRESSION BUG** in Flutter SDK, see [issue 162839](https://github.com/flutter/flutter/issues/162839). The issue in Flutter SDK has been fixed via [PR 162880](https://github.com/flutter/flutter/pull/162880). However, this fix will never apply to Flutter versions 3.27.0 to at least 3.29.0. It may land as a cherry-picked hotfix in Flutter 3.29.1 or later minor release of Flutter 3.29. The FIX released here in this version of FlexColorScheme, adds a workaround to this issue. Without this workaround patch, the icon color on the above-mentioned buttons will not work correctly. The used workaround patch will also work correctly after Flutter [PR 162880](https://github.com/flutter/flutter/pull/162880) lands in Flutter.
20+
21+
### Themes Playground
22+
23+
* The above-mentioned Flutter SDK issue was added to "Known issues" in info expands on the Buttons and Segmented Buttons Playground panels.
24+
525
## 8.1.0
626

727
**Dec 29, 2024**

‎LICENSE

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
BSD 3-Clause License
22

3-
FlexColorScheme Copyright (c) 2020 - 2024
3+
FlexColorScheme Copyright (c) 2020 - 2025
44
Mike Rydstrom (Twitter @RydMike GitHub rydmike)
55
All rights reserved.
66

‎README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ You should use the same major version of **Themes Playground** as the `flex_colo
166166

167167
| Name | Version | Link |
168168
|-------|---------|--------------------------------------------------------------|
169-
| V8.1 | V8.1.0 | https://rydmike.com/flexcolorscheme/themesplayground-latest |
169+
| V8.1 | V8.1.1 | https://rydmike.com/flexcolorscheme/themesplayground-latest |
170170
| V8.0 | V8.0.2 | https://rydmike.com/flexcolorscheme/themesplayground-v8-0 |
171171
| V7.3 | V7.3.1 | https://rydmike.com/flexcolorscheme/themesplayground-v7-3 |
172172
| V7.2 | V7.2.0 | https://rydmike.com/flexcolorscheme/themesplayground-v7-2 |

‎example/LICENSE

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
BSD 3-Clause License
22

3-
FlexColorScheme usage examples Copyright (c) 2020, 2021, 2022
3+
FlexColorScheme usage examples Copyright (c) 2020 - 2025
44
Mike Rydstrom (Twitter @RydMike GitHub rydmike)
55
All rights reserved.
66

‎example/devtools_options.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
description: This file stores settings for Dart & Flutter DevTools.
2+
documentation: https://docs.flutter.dev/tools/devtools/extensions#configure-extension-enablement-states
3+
extensions:

‎example/lib/example5_themes_playground/utils/generate_theme_dart_code.dart

-1
Original file line numberDiff line numberDiff line change
@@ -2387,7 +2387,6 @@ String generateThemeDartCode(ThemeController controller) {
23872387
'/// MaterialApp(\n'
23882388
'/// theme: AppTheme.light,\n'
23892389
'/// darkTheme: AppTheme.dark,\n'
2390-
'/// :\n'
23912390
'/// );\n'
23922391
'abstract final class AppTheme {\n'
23932392
' // The defined light theme.\n'

‎example/lib/example5_themes_playground/widgets/panels/buttons/buttons_panel.dart

+50
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,18 @@ class ButtonsPanel extends StatelessWidget {
1717
});
1818
final ThemeController controller;
1919

20+
static final Uri _iconColorIssue162839 = Uri(
21+
scheme: 'https',
22+
host: 'github.com',
23+
path: 'flutter/flutter/issues/162839',
24+
);
25+
26+
static final Uri _iconColorPR162880 = Uri(
27+
scheme: 'https',
28+
host: 'github.com',
29+
path: 'flutter/flutter/pull/162880',
30+
);
31+
2032
static final Uri _fcsFlutterIssue118063 = Uri(
2133
scheme: 'https',
2234
host: 'github.com',
@@ -297,6 +309,44 @@ class ButtonsPanel extends StatelessWidget {
297309
valueDefaultDisabledLabel: useMaterial3 ? 'stadium' : '4 dp',
298310
),
299311
const Divider(),
312+
ListTileReveal(
313+
dense: true,
314+
title: const Text('Known issue on ALL Buttons'),
315+
subtitleReveal: RichText(
316+
text: TextSpan(
317+
children: <TextSpan>[
318+
TextSpan(
319+
style: spanTextStyle,
320+
text: 'In Flutter 3.27.0 to 3.27.4 and also at least 3.29.0 '
321+
'the color of icons on ElevatedButton, FilledButton, '
322+
'OutlinedButton and TextButton do not follow the '
323+
'foreground color of the button, see ',
324+
),
325+
LinkTextSpan(
326+
style: linkStyle,
327+
uri: _iconColorIssue162839,
328+
text: '(issue #162839)',
329+
),
330+
TextSpan(
331+
style: spanTextStyle,
332+
text: '. This issue has been corrected via ',
333+
),
334+
LinkTextSpan(
335+
style: linkStyle,
336+
uri: _iconColorPR162880,
337+
text: '(PR #162880)',
338+
),
339+
//
340+
TextSpan(
341+
style: spanTextStyle,
342+
text: '. This fix has not yet landed in Flutter stable 3.29. '
343+
'FlexColorScheme 8.1.1 and later, include a workaround '
344+
'patch for this issue.',
345+
),
346+
],
347+
),
348+
),
349+
),
300350
const ListTileReveal(
301351
dense: true,
302352
title: Text('More settings with the API'),

‎example/lib/example5_themes_playground/widgets/panels/segmented_buttons/segmented_buttons_panel.dart

+48-9
Original file line numberDiff line numberDiff line change
@@ -14,25 +14,37 @@ class SegmentedButtonsPanel extends StatelessWidget {
1414
const SegmentedButtonsPanel(this.controller, {super.key});
1515
final ThemeController controller;
1616

17+
static final Uri _iconColorIssue162839 = Uri(
18+
scheme: 'https',
19+
host: 'github.com',
20+
path: 'flutter/flutter/issues/162839',
21+
);
22+
23+
static final Uri _iconColorPR162880 = Uri(
24+
scheme: 'https',
25+
host: 'github.com',
26+
path: 'flutter/flutter/pull/162880',
27+
);
28+
1729
static final Uri _segmentNotTransparentIssue123292 = Uri(
1830
scheme: 'https',
1931
host: 'github.com',
20-
path: 'flutter/flutter/pull/123292',
32+
path: 'flutter/flutter/issues/123292',
2133
);
2234
static final Uri _segmentWrongHeightIssue121493 = Uri(
2335
scheme: 'https',
2436
host: 'github.com',
25-
path: 'flutter/flutter/pull/121493',
37+
path: 'flutter/flutter/issues/121493',
2638
);
2739
static final Uri _segmentWrongOverlayIssue123308 = Uri(
2840
scheme: 'https',
2941
host: 'github.com',
30-
path: 'flutter/flutter/pull/123308',
42+
path: 'flutter/flutter/issues/123308',
3143
);
3244
static final Uri _segmentNotM3SpecIssue119733 = Uri(
3345
scheme: 'https',
3446
host: 'github.com',
35-
path: 'flutter/flutter/pull/119733',
47+
path: 'flutter/flutter/issues/119733',
3648
);
3749

3850
@override
@@ -221,7 +233,32 @@ class SegmentedButtonsPanel extends StatelessWidget {
221233
children: <TextSpan>[
222234
TextSpan(
223235
style: spanTextStyle,
224-
text: 'In Flutter 3.7 the SegmentedButton has a few '
236+
text: 'In Flutter 3.27.0 to 3.27.4 and also at least 3.29.0 '
237+
'the color of icons on SegmentedButton do not follow the '
238+
'foreground color of the button, see ',
239+
),
240+
LinkTextSpan(
241+
style: linkStyle,
242+
uri: _iconColorIssue162839,
243+
text: '(issue #162839)',
244+
),
245+
TextSpan(
246+
style: spanTextStyle,
247+
text: '. This issue has been corrected via ',
248+
),
249+
LinkTextSpan(
250+
style: linkStyle,
251+
uri: _iconColorPR162880,
252+
text: '(PR #162880)',
253+
),
254+
//
255+
TextSpan(
256+
style: spanTextStyle,
257+
text: '. This fix has not yet landed in Flutter stable 3.29. '
258+
'FlexColorScheme 8.1.1 and later, include a workaround '
259+
'patch for this issue.'
260+
'\n\n'
261+
'In Flutter 3.7 the SegmentedButton has a few '
225262
'small issues, like background is not transparent ',
226263
),
227264
LinkTextSpan(
@@ -241,9 +278,8 @@ class SegmentedButtonsPanel extends StatelessWidget {
241278
),
242279
TextSpan(
243280
style: spanTextStyle,
244-
text: ', these issues are fixed in Flutter 3.10.\n'
245-
'Additionally min height or size '
246-
'cannot be set ',
281+
text: ', these issues are fixed in Flutter 3.10.\n\n'
282+
'The minimum height or size cannot be set, see ',
247283
),
248284
LinkTextSpan(
249285
style: linkStyle,
@@ -261,7 +297,10 @@ class SegmentedButtonsPanel extends StatelessWidget {
261297
),
262298
TextSpan(
263299
style: spanTextStyle,
264-
text: ', these have no fixes yet.',
300+
text: '. The former issue is closed, but NOT fixed! '
301+
'The PR that closed it only fixed the wrong spec '
302+
'default size, but did not make it customizable. The '
303+
'latter issue is still open and has no fix yet.',
265304
),
266305
],
267306
),

‎example/lib/example_copy_paste_from_playground/app_theme.dart

+1-2
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,13 @@ import 'package:flutter/material.dart';
88
/// Use same major flex_color_scheme package version. If you use a
99
/// lower minor version, some properties may not be supported.
1010
/// In that case, remove them after copying this theme to your
11-
/// app or upgrade package to version 8.0.2.
11+
/// app or upgrade package to version 8.1.1.
1212
///
1313
/// Use in [MaterialApp] like this:
1414
///
1515
/// MaterialApp(
1616
/// theme: AppTheme.light,
1717
/// darkTheme: AppTheme.dark,
18-
/// :
1918
/// );
2019
abstract final class AppTheme {
2120
// The defined light theme.

‎example/lib/shared/const/app.dart

+3-3
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@ abstract final class App {
4747
// build numbers.
4848
static const String versionMajor = '8';
4949
static const String versionMinor = '1';
50-
static const String versionPatch = '0';
50+
static const String versionPatch = '1';
5151
static const String versionBuild = '01';
5252
static const String versionFull = '$versionMajor.$versionMinor.$versionPatch'
5353
'\nBuild-$versionBuild';
5454
static const String version = '$versionMajor.$versionMinor.$versionPatch';
55-
static const String flutterVersion = 'stable 3.27.1 (canvaskit$buildType)';
56-
static const String copyright = '© 2020 - 2024';
55+
static const String flutterVersion = 'stable 3.29.0 (canvaskit$buildType)';
56+
static const String copyright = '© 2020 - 2025';
5757
static const String author = 'Mike Rydstrom';
5858
static const String license = 'BSD 3-Clause License';
5959
static const String icon = 'assets/images/app_icon.png';

‎example/macos/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme

+1
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@
5959
ignoresPersistentStateOnLaunch = "NO"
6060
debugDocumentVersioning = "YES"
6161
debugServiceExtension = "internal"
62+
enableGPUValidationMode = "1"
6263
allowLocationSimulation = "YES">
6364
<BuildableProductRunnable
6465
runnableDebuggingMode = "0">

0 commit comments

Comments
 (0)