Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor getters similar to flow #1081

Closed
Tracked by #1077
andreivladbrg opened this issue Nov 8, 2024 · 0 comments
Closed
Tracked by #1077

Refactor getters similar to flow #1081

andreivladbrg opened this issue Nov 8, 2024 · 0 comments
Assignees
@andreivladbrg
Labels
effort: medium Default level of effort. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.

Comments

@andreivladbrg
Copy link
Member

Since the getters test logic is very repetitive, we should move all tests into a single file, similar to flow:

https://github.com/sablier-labs/flow/tree/main/tests/integration/concrete/getters
@andreivladbrg andreivladbrg added type: test Adding, updating, or removing tests. priority: 2 We will do our best to deal with this. work: clear Sense-categorize-respond. The relationship between cause and effect is clear. effort: medium Default level of effort. labels Nov 8, 2024
@smol-ninja smol-ninja mentioned this issue Nov 9, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreivladbrg andreivladbrg

Labels
effort: medium Default level of effort. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: clear Sense-categorize-respond. The relationship between cause and effect is clear.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smol-ninja @andreivladbrg