Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull a git repo and then start it up , when a request hits the proxy #430

Closed
gedw99 opened this issue Oct 24, 2024 · 4 comments
Closed

Pull a git repo and then start it up , when a request hits the proxy #430

gedw99 opened this issue Oct 24, 2024 · 4 comments

Comments

@gedw99
Copy link

gedw99 commented Oct 24, 2024

Does this also hold the request whilst the docker is being started up ?

I know caddy natively supports this if it’s configured . It will wait for the proxied app to start up and then let the request through .

It would be cool if you could just set up the GitHub repo that a caddy proxy represents . Then when a request comes in , it would pull the docker that was build to run the repo , and then pull the repo contents .

it would make it easy to run hugo based projects where the markdown is produced after the repo with the markdown is pulled or js based projects where the code would be compiled after the repo is pulled .

@acouvreur
Copy link
Member

Does this also hold the request whilst the docker is being started up ?

The blocking strategy holds the request until the docker container is up and ready.
So that takes into account starting up the docker container.

I know caddy natively supports this if it’s configured . It will wait for the proxied app to start up and then let the request through .

Do you mean the Sablier plugin ? Or Caddy itself ? If so, could you please share some documentation about that behavior.

It would be cool if you could just set up the GitHub repo that a caddy proxy represents . Then when a request comes in , it would pull the docker that was build to run the repo , and then pull the repo contents .

it would make it easy to run hugo based projects where the markdown is produced after the repo with the markdown is pulled or js based projects where the code would be compiled after the repo is pulled .

So instead of linking pre-built containers, you'd want to be able to link not-yet-built containers ?

Could you give an example on how you'd configure this as if this feature existed ?

Like how would you configure the reverse proxy, the sablier plugin and sablier itself.

@gedw99
Copy link
Author

gedw99 commented Oct 28, 2024

Hey @acouvreur

in caddy it uses the “try” keyword in the config .

I tried to find an example for it but could not find though .

@acouvreur
Copy link
Member

Sablier currently will only stop and start instances that already exist only

@acouvreur acouvreur closed this as not planned Won't fix, can't repro, duplicate, stale Mar 3, 2025
@gedw99
Copy link
Author

gedw99 commented Mar 3, 2025

thanks I got another angle on this here:

basecamp/kamal-proxy#114 (comment)

It can pause and drain .

Figured its worth letting you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants