Fix external graph generators leaking file descriptors #41227
Merged
+164
−164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ordoviz
force-pushed
the
fix-too-many-open-files
branch
from
d277790 to
f0b0dc3
Compare
dcoudert
reviewed
Nov 24, 2025
Contributor
dcoudert
left a comment
dcoudert
left a comment
There was a problem hiding this comment.
Nice improvement.
In digraph_generators.py, there is also method nauty_directg.
This fixes a "Too many open files" error when running
import resource
max_open_files = 20
resource.setrlimit(resource.RLIMIT_NOFILE,(max_open_files,max_open_files))
for _ in range(max_open_files):
for G in graphs.nauty_geng("9"):
break
Ordoviz
force-pushed
the
fix-too-many-open-files
branch
from
f0b0dc3 to
543dbd6
Compare
Contributor
Author
|
I added a context manager for the |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 26, 2025
sagemathgh-41227: Fix external graph generators leaking file descriptors This fixes a "Too many open files" error when running ```sage import resource max_open_files = 20 resource.setrlimit(resource.RLIMIT_NOFILE,(max_open_files,max_open_files )) for _ in range(max_open_files): for G in graphs.nauty_geng("9"): break ``` The above relies on the fact that `geng 9` takes a while to finish. While the first `geng 9` process is still running, up to 20 other processes are started until the operating system runs out of file descriptors. This pull request fixes this by making sure a process is terminated when it's no longer needed. I did not (and do not plan to) add any tests for this. URL: sagemath#41227 Reported by: Lennard Hofmann Reviewer(s): David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 1, 2025
sagemathgh-41227: Fix external graph generators leaking file descriptors This fixes a "Too many open files" error when running ```sage import resource max_open_files = 20 resource.setrlimit(resource.RLIMIT_NOFILE,(max_open_files,max_open_files )) for _ in range(max_open_files): for G in graphs.nauty_geng("9"): break ``` The above relies on the fact that `geng 9` takes a while to finish. While the first `geng 9` process is still running, up to 20 other processes are started until the operating system runs out of file descriptors. This pull request fixes this by making sure a process is terminated when it's no longer needed. I did not (and do not plan to) add any tests for this. URL: sagemath#41227 Reported by: Lennard Hofmann Reviewer(s): David Coudert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a "Too many open files" error when running
The above relies on the fact that
geng 9takes a while to finish. While the firstgeng 9process is still running, up to 20 other processes are started until the operating system runs out of file descriptors. This pull request fixes this by making sure a process is terminated when it's no longer needed.I did not (and do not plan to) add any tests for this.