travis and eslint upgrade

Author: sagiegurari

.eslintrc

@@ -20,7 +20,6 @@
     "max-nested-callbacks": 0,
     "one-var": 0,
     "padded-blocks": 0,
-    "quote-props": 0,
     "sort-vars": 0,
     "space-before-blocks": 0,
     "space-in-brackets": 0,
@@ -32,23 +31,59 @@
     "no-undefined": 0,
     "func-names": 0,
     "consistent-this": 0,
-
-    "valid-jsdoc": [1, {
-      "requireReturn": false,
-      "prefer": {
-        "return": "returns"
+    "valid-jsdoc": [
+      1,
+      {
+        "requireReturn": false,
+        "prefer": {
+          "return": "returns"
+        }
       }
-    }],
-
-    "no-comma-dangle": 2,
+    ],
+    "quote-props": [
+      2,
+      "as-needed"
+    ],
+    "constructor-super": 2,
+    "no-this-before-super": 2,
+    "no-unexpected-multiline": 2,
+    "array-bracket-spacing": [
+      2,
+      "never"
+    ],
+    "arrow-parens": 2,
+    "arrow-spacing": [
+      2,
+      {
+        "before": true,
+        "after": true
+      }
+    ],
+    "callback-return": 2,
+    "id-length": [
+      2,
+      {
+        "min": 2
+      }
+    ],
+    "no-class-assign": 2,
+    "no-const-assign": 2,
+    "no-implicit-coercion": 2,
+    "no-invalid-this": 2,
+    "no-useless-call": 2,
+    "require-yield": 2,
+    "comma-dangle": [
+      2,
+      "never"
+    ],
     "no-cond-assign": 2,
     "no-console": 2,
     "no-constant-condition": 2,
     "no-control-regex": 2,
     "no-debugger": 2,
     "no-dupe-keys": 2,
     "no-empty": 2,
-    "no-empty-class": 2,
+    "no-empty-character-class": 2,
     "no-ex-assign": 2,
     "no-extra-boolean-cast": 2,
     "no-extra-semi": 2,
@@ -59,7 +94,6 @@
     "no-negated-in-lhs": 2,
     "no-obj-calls": 2,
     "no-regex-spaces": 2,
-    "no-reserved-keys": 2,
     "no-sparse-arrays": 2,
     "no-unreachable": 2,
     "use-isnan": 2,
@@ -104,9 +138,10 @@
     "radix": 2,
     "wrap-iife": 2,
     "yoda": 2,
-    "global-strict": 2,
-    "no-extra-strict": 2,
-    "strict": 2,
+    "strict": [
+      2,
+      "function"
+    ],
     "no-catch-shadow": 2,
     "no-delete-var": 2,
     "no-label-var": 2,
@@ -125,11 +160,17 @@
     "no-sync": 2,
     "brace-style": 2,
     "camelcase": 2,
-    "comma-spacing": [2, {
-      "before": false,
-      "after": true
-    }],
-    "comma-style": [2, "last"],
+    "comma-spacing": [
+      2,
+      {
+        "before": false,
+        "after": true
+      }
+    ],
+    "comma-style": [
+      2,
+      "last"
+    ],
     "eol-last": 2,
     "key-spacing": 2,
     "new-cap": 2,
@@ -139,13 +180,18 @@
     "no-mixed-spaces-and-tabs": 2,
     "no-nested-ternary": 2,
     "no-new-object": 2,
-    "no-space-before-semi": 2,
+    "semi-spacing": [
+      2,
+      {
+        "before": false,
+        "after": true
+      }
+    ],
     "no-spaced-func": 2,
     "no-ternary": 2,
     "no-trailing-spaces": 2,
     "no-multiple-empty-lines": 2,
     "no-underscore-dangle": 2,
-    "no-wrap-func": 2,
     "quotes": [
       2,
       "single",
@@ -155,9 +201,20 @@
     "space-after-keywords": 2,
     "space-infix-ops": 2,
     "space-return-throw-case": 2,
-    "spaced-line-comment": [2, "never"],
+    "spaced-comment": [
+      2,
+      "never",
+      {
+        "exceptions": [
+          "/*"
+        ]
+      }
+    ],
     "wrap-regex": 2,
-    "max-params": [2, 6],
+    "max-params": [
+      2,
+      6
+    ],
     "no-bitwise": 2
   }
 }

.travis.yml

@@ -4,3 +4,4 @@ node_js:
 before_script:
   - npm install -g [email protected]
   - bower install
+sudo: false

Gruntfile.js

@@ -123,7 +123,7 @@ module.exports = function (grunt) {
             api: {
                 options: {
                     index: true,
-                    'private': false
+                    private: false
                 },
                 src: 'angular-web-notification.js',
                 dest: 'docs/api.md'

README.md

@@ -79,7 +79,7 @@ See full docs at: [API Docs](docs/api.md)
 
 | Date        | Version | Description |
 | ----------- | ------- | ----------- |
-| 2015-06-24  | v0.0.20 | Maintenance |
+| 2015-08-02  | v0.0.21 | Maintenance |
 | 2015-02-16  | v0.0.7  | Automatic unit tests via karma |
 | 2015-02-05  | v0.0.5  | Doc changes |
 | 2014-12-30  | v0.0.4  | Doc changes |

angular-web-notification.js

@@ -1,5 +1,13 @@
 /*global notify: false, angular: false */
 
+/**
+ * 'showNotification' callback.
+ *
+ * @callback ShowNotificationCallback
+ * @param {error} [error] - The error object in case of any error
+ * @param {function} [hide] - The hide notification function
+ */
+
 (function (notifyLib) {
     'use strict';
 
@@ -132,7 +140,8 @@
              * @public
              * @param {string} [title] - The notification title text (defaulted to empty string if null is provided)
              * @param {object} [options] - Holds the notification data (web notification API spec for more info)
-             * @param {function} callback - Called after the show is handled.
+             * @param {ShowNotificationCallback} callback - Called after the show is handled.
+             * @returns {*} The callback function return value or undefined
              * @example
              * ```js
              * webNotification.showNotification('Example Notification', {
@@ -164,18 +173,20 @@
                     var hideNotification = null;
                     if (isEnabled()) {
                         hideNotification = createAndDisplayNotification(title, options);
-                        callback(null, hideNotification);
-                    } else if (service.allowRequest) {
+                        return callback(null, hideNotification);
+                    }
+
+                    if (service.allowRequest) {
                         notifyLib.requestPermission(function onRequestDone() {
                             if (isEnabled()) {
                                 hideNotification = createAndDisplayNotification(title, options);
-                                callback(null, hideNotification);
-                            } else {
-                                callback(new Error('Notifications are not enabled.'), null);
+                                return callback(null, hideNotification);
                             }
+
+                            return callback(new Error('Notifications are not enabled.'), null);
                         });
                     } else {
-                        callback(new Error('Notifications are not enabled.'), null);
+                        return callback(new Error('Notifications are not enabled.'), null);
                     }
                 }
             }

bower.json

@@ -1,6 +1,6 @@
 {
   "name": "angular-web-notification",
-  "version": "0.0.20",
+  "version": "0.0.21",
   "authors": [
     "Sagie Gur-Ari <[email protected]>"
   ],

docs/api.md

@@ -1,3 +1,15 @@
+## Objects
+<dl>
+<dt><a href="#webNotification">webNotification</a> ⇒ <code>object</code></dt>
+<dd><p>The web notification service wraps the HTML 5 Web Notifications API as an angular service.</p>
+</dd>
+</dl>
+## Typedefs
+<dl>
+<dt><a href="#ShowNotificationCallback">ShowNotificationCallback</a> : <code>function</code></dt>
+<dd><p>&#39;showNotification&#39; callback.</p>
+</dd>
+</dl>
 <a name="webNotification"></a>
 ## webNotification ⇒ <code>object</code>
 The web notification service wraps the HTML 5 Web Notifications API as an angular service.
@@ -9,26 +21,27 @@ The web notification service wraps the HTML 5 Web Notifications API as an angula
 
 * [webNotification](#webNotification) ⇒ <code>object</code>
   * [.allowRequest](#webNotification.allowRequest)
-  * [.showNotification([title], [options], callback)](#webNotification.showNotification)
+  * [.showNotification([title], [options], callback)](#webNotification.showNotification) ⇒ <code>\*</code>
 
 <a name="webNotification.allowRequest"></a>
 ### webNotification.allowRequest
 True to enable automatic requesting of permissions if needed.
 
 **Access:** public  
 <a name="webNotification.showNotification"></a>
-### webNotification.showNotification([title], [options], callback)
+### webNotification.showNotification([title], [options], callback) ⇒ <code>\*</code>
 Shows the notification based on the provided input.<br>
 The callback invoked will get an error object (in case of an error, null in
 case of no errors) and a 'hide' function which can be used to hide the notification.
 
+**Returns**: <code>\*</code> - The callback function return value or undefined  
 **Access:** public  
 
 | Param | Type | Description |
 | --- | --- | --- |
 | [title] | <code>string</code> | The notification title text (defaulted to empty string if null is provided) |
 | [options] | <code>object</code> | Holds the notification data (web notification API spec for more info) |
-| callback | <code>function</code> | Called after the show is handled. |
+| callback | <code>[ShowNotificationCallback](#ShowNotificationCallback)</code> | Called after the show is handled. |
 
 **Example**  
 ```js
@@ -45,3 +58,14 @@ webNotification.showNotification('Example Notification', {
    }
 });
 ```
+<a name="ShowNotificationCallback"></a>
+## ShowNotificationCallback : <code>function</code>
+'showNotification' callback.
+
+**Kind**: global typedef  
+
+| Param | Type | Description |
+| --- | --- | --- |
+| [error] | <code>error</code> | The error object in case of any error |
+| [hide] | <code>function</code> | The hide notification function |
+