The split pane for renaming would change the pane height messing the layout

[liangkarl]

Hello,

Thanks for giving us such a great tool to work with tmux. However, I found that the rename function would change the height of panes. For example, if I create three panes horizontally and rename the window, two of the panes' heights would change after the rename pane closed. Could you change the rename pane to a popup window? It would help a lot.

Thanks.

[liangkarl]

I've tested the commands in my environment. It looks fine to me.

# for window
tmux popup -h 3 -E -T "Window Name:" bash -c "read window_name && echo \"\$window_name\" > /tmp/tmux_fzf_window_name" &
# for session
tmux popup -h 3 -E -T "Session Name:" bash -c "read session_name && echo \"\$session_name\" > /tmp/tmux_fzf_session_name" &

[sainnhe]

Sorry for late reply.

This is because tmux-fzf currently uses a new pane to handle renaming. I once tried to use command prompt but it has some issues #83 #84

Using popup menu to handle user input requires a major refactoring, because older versions of tmux doesn't support popup menu, and we need to switch to panes in older versions of tmux.

I haven't had much time to implement this recently, if you are interested in implementing this feature, welcome to issue a PR.

[liangkarl]

I think it can be solved by calling different functions for different tmux versions if you want. Also, you already have the tested codes. What you can do is add a version-checking function.
On the other hand, typing in the command line is the oldest way you use, and it is a good idea to solve the problem.
Of course, it's my opinion. : )

[sainnhe]

Sounds good. PR is welcome.