Skip to content

Commit 8ac9091

Browse files
kevinparkersonkevinparkerson
committed
removing all warnings from CI
1 parent 32bd78d commit 8ac9091

File tree

88 files changed

+374
-245
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

88 files changed

+374
-245
lines changed

‎.storybook/webpack.config.js

+17-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,20 @@
11
/* eslint-env node */
2-
const baseConfig = require('../webpack.config');
2+
const webpackConfig = require('../webpack.config');
33

4-
const config = Object.assign({}, baseConfig);
4+
// Export a function. Accept the base config as the only param.
5+
module.exports = async ({ config /*, mode */}) => {
6+
// `mode` has a value of 'DEVELOPMENT' or 'PRODUCTION'
7+
// You can change the configuration based on that.
8+
// 'PRODUCTION' is used when building the static version of storybook.
59

6-
module.exports = config;
10+
// Make whatever fine-grained changes you need to config
11+
config.mode = webpackConfig.mode;
12+
config.resolve = { ...config.resolve, ...webpackConfig.resolve };
13+
config.devtool = webpackConfig.devtool;
14+
config.module.rules = config.module.rules.concat(webpackConfig.module.rules);
15+
config.performance = webpackConfig.performance;
16+
config.plugins = config.plugins.concat(webpackConfig.plugins);
17+
18+
// Return the altered config
19+
return config;
20+
};

‎components/accordion/__docs__/__snapshots__/storybook-stories.storyshot

+3
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ exports[`DOM snapshots SLDSAccordion Base 1`] = `
2222
>
2323
<button
2424
aria-controls="1-accordion-panel"
25+
aria-expanded={false}
2526
className="slds-button slds-button_reset slds-accordion__summary-action"
2627
disabled={false}
2728
id="1-accordion-button"
@@ -102,6 +103,7 @@ exports[`DOM snapshots SLDSAccordion Base 1`] = `
102103
>
103104
<button
104105
aria-controls="2-accordion-panel"
106+
aria-expanded={false}
105107
className="slds-button slds-button_reset slds-accordion__summary-action"
106108
disabled={false}
107109
id="2-accordion-button"
@@ -182,6 +184,7 @@ exports[`DOM snapshots SLDSAccordion Base 1`] = `
182184
>
183185
<button
184186
aria-controls="3-accordion-panel"
187+
aria-expanded={false}
185188
className="slds-button slds-button_reset slds-accordion__summary-action"
186189
disabled={false}
187190
id="3-accordion-button"

‎components/accordion/__examples__/base.jsx

+14-12
Original file line numberDiff line numberDiff line change
@@ -88,18 +88,20 @@ class Example extends React.Component {
8888
return (
8989
<IconSettings iconPath="/assets/icons">
9090
<Accordion id="base-example-accordion">
91-
{this.state.items.map((item, i) => (
92-
<AccordionPanel
93-
expanded={this.state.expandedPanels[item.id]}
94-
id={item.id}
95-
panelContentActions={this.menuDropdown(item)}
96-
key={item.id}
97-
onTogglePanel={(event) => this.togglePanel(event, item)}
98-
summary={item.summary}
99-
>
100-
{item.details}
101-
</AccordionPanel>
102-
))}
91+
{this.state.items.map((item, i) => {
92+
return (
93+
<AccordionPanel
94+
expanded={!!this.state.expandedPanels[item.id]}
95+
id={item.id}
96+
panelContentActions={this.menuDropdown(item)}
97+
key={item.id}
98+
onTogglePanel={(event) => this.togglePanel(event, item)}
99+
summary={item.summary}
100+
>
101+
{item.details}
102+
</AccordionPanel>
103+
);
104+
})}
103105
</Accordion>
104106
</IconSettings>
105107
);

‎components/app-launcher/check-props.js

+1
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ if (process.env.NODE_ENV !== 'production') {
4949
} else if (COMPONENT === APP_LAUNCHER_SECTION) {
5050
componentIsDeprecated(
5151
COMPONENT,
52+
props,
5253
'App Launcher Section has been deprecated. Please use APP_LAUNCHER_EXPANDABLE_SECTION instead.'
5354
);
5455
} else if (COMPONENT === APP_LAUNCHER_TILE) {

‎components/builder-header/__docs__/__snapshots__/storybook-stories.storyshot

+1
Original file line numberDiff line numberDiff line change
@@ -403,6 +403,7 @@ exports[`DOM snapshots SLDSBuilderHeader After Successful Save 1`] = `
403403
onFocus={[Function]}
404404
onMouseEnter={[Function]}
405405
onMouseLeave={[Function]}
406+
tabIndex={0}
406407
>
407408
Saved 5 mins ago
408409
</span>

‎components/builder-header/__examples__/after-successful-save.jsx

+4-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,10 @@ const Example = (props) => (
5555
align="bottom"
5656
content="Last modified on June 1, 2018 by SysAdmin"
5757
>
58-
<span className="slds-color__text_gray-10 slds-align-middle slds-m-right_small">
58+
<span
59+
className="slds-color__text_gray-10 slds-align-middle slds-m-right_small"
60+
tabIndex={0} // eslint-disable-line jsx-a11y/no-noninteractive-tabindex
61+
>
5962
Saved 5 mins ago
6063
</span>
6164
</Tooltip>

‎components/builder-header/__examples__/base-with-page-type-editable.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ class Example extends React.Component {
9898
label="Page Type"
9999
value={this.state.pageType}
100100
onChange={this.onChange('page-type')}
101-
required="true"
101+
required
102102
errorText={this.state.errorText}
103103
/>
104104
</div>

‎components/button/__docs__/storybook-stories.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ storiesOf(BUTTON, module)
6565
'Small Icon Hint inverse',
6666
() =>
6767
getIconButton({
68-
assistiveText: 'Hint',
68+
assistiveText: { icon: 'Hint' },
6969
iconCategory: 'utility',
7070
iconName: 'down',
7171
iconVariant: 'border',

‎components/card/__docs__/storybook-stories.jsx

+1
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,7 @@ storiesOf(CARD, module)
192192
name="inline-edit-standard"
193193
value="Write your own heading"
194194
id="inline-edit-standard"
195+
silenceDeprecationWarning
195196
/>
196197
}
197198
/>

‎components/color-picker/__examples__/default.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import IconSettings from '~/components/icon-settings';
55
import ColorPicker from '~/components/color-picker';
66

77
class Example extends React.Component {
8-
static displayName = 'DatepickerExample';
8+
static displayName = 'ColorPickerExample';
99

1010
render() {
1111
return (

‎components/color-picker/__tests__/color-picker.browser-test.jsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -390,9 +390,9 @@ describe('SLDSColorPicker', function describeFunction() {
390390
});
391391

392392
describe('saturation-value grid', function describeFunction5() {
393-
it('click sets color using coordinates', function() {
394-
this.skip('too dependent on browser calculations');
395-
});
393+
// it('click sets color using coordinates', function() {
394+
// this.skip('too dependent on browser calculations');
395+
// });
396396

397397
it('up key causes color value to go up', function(done) {
398398
wrapper = mount(

‎components/color-picker/private/hsv-color.jsx

+4-2
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,9 @@ class HsvColor extends React.Component {
154154
checked={!this.isTransparent()}
155155
id={`color-picker-active-working-color-swatch-${this.props.id}`}
156156
key="working-color"
157-
label={this.props.labels.customTabActiveWorkingColorSwatch}
157+
labels={{
158+
label: this.props.labels.customTabActiveWorkingColorSwatch,
159+
}}
158160
style={swatchStyle}
159161
value={workingColor.hex}
160162
variant="swatch"
@@ -163,7 +165,7 @@ class HsvColor extends React.Component {
163165
checked={this.isTransparent()}
164166
id={`color-picker-transparent-swatch-${this.props.id}`}
165167
key="transparent"
166-
label={this.props.labels.customTabTransparentSwatch}
168+
labels={{ label: this.props.labels.customTabTransparentSwatch }}
167169
style={transparentSwatchStyle}
168170
value="" // transparent
169171
variant="swatch"

‎components/combobox/__docs__/__snapshots__/storybook-stories.storyshot

+2
Original file line numberDiff line numberDiff line change
@@ -1682,6 +1682,7 @@ exports[`DOM snapshots SLDSCombobox Base Menu Item Disabled With Tooltip Open 1`
16821682
"cursor": "default",
16831683
}
16841684
}
1685+
tabIndex={0}
16851686
>
16861687
<span
16871688
className="slds-media__figure"
@@ -1824,6 +1825,7 @@ exports[`DOM snapshots SLDSCombobox Base Menu Item Disabled With Tooltip Open 1`
18241825
"cursor": "default",
18251826
}
18261827
}
1828+
tabIndex={0}
18271829
>
18281830
<span
18291831
className="slds-media__figure"

‎components/combobox/__examples__/dialog.jsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/* eslint-disable no-console, react/prop-types */
22
import React from 'react';
3-
import Checkbox from '~/components/forms/checkbox';
3+
import Checkbox from '~/components/checkbox';
44
import Combobox from '~/components/combobox';
55
import IconSettings from '~/components/icon-settings';
66
import Popover from '~/components/popover';
@@ -101,7 +101,7 @@ class Example extends React.Component {
101101
id={`checkbox-${i}`}
102102
key={`checkbox-${i + 1}`}
103103
labels={{ label: language }}
104-
onChange={(checked, e) => {
104+
onChange={(e, { checked }) => {
105105
this.handleCheckboxChange(
106106
checked,
107107
e.target,

‎components/combobox/__tests__/combobox.browser-test.jsx

+10-8
Original file line numberDiff line numberDiff line change
@@ -264,14 +264,16 @@ describe('SLDSCombobox', function describeFunction() {
264264
name="search"
265265
/>
266266
),
267-
label: (searchTerm) => [
268-
searchTerm && searchTerm.length > 0 ? (
269-
<span className="slds-text-title_bold">{`"${searchTerm}" `}</span>
270-
) : (
271-
'Search '
272-
),
273-
'in Accounts',
274-
],
267+
label: (searchTerm) => (
268+
<React.Fragment>
269+
{searchTerm && searchTerm.length > 0 ? (
270+
<span className="slds-text-title_bold">{`"${searchTerm}" `}</span>
271+
) : (
272+
'Search '
273+
)}
274+
in Accounts
275+
</React.Fragment>
276+
),
275277
},
276278
]}
277279
optionsAddItem={[

‎components/combobox/private/menu.jsx

+14-10
Original file line numberDiff line numberDiff line change
@@ -172,14 +172,16 @@ const setBold = (label, searchTerm) => {
172172
}
173173
const position = label.toLowerCase().indexOf(searchTerm.toLowerCase());
174174
if (position > -1) {
175-
return [
176-
label.substr(0, position),
177-
<span className="slds-text-title_bold">{`${label.substr(
178-
position,
179-
searchTerm.length
180-
)}`}</span>,
181-
label.substr(position + searchTerm.length),
182-
];
175+
return (
176+
<React.Fragment>
177+
{label.substr(0, position)}
178+
<span className="slds-text-title_bold">{`${label.substr(
179+
position,
180+
searchTerm.length
181+
)}`}</span>
182+
{label.substr(position + searchTerm.length)}
183+
</React.Fragment>
184+
);
183185
}
184186
return label;
185187
};
@@ -275,7 +277,7 @@ const Menu = (props) => {
275277
if (optionData.type === 'footer') {
276278
return (
277279
<li
278-
key={`menu-header-${optionData.id}}`}
280+
key={`menu-footer-${optionData.id}}`}
279281
role="presentation"
280282
className="slds-listbox__item"
281283
>
@@ -323,6 +325,7 @@ const Menu = (props) => {
323325
aria-selected={active}
324326
{...disabledProps}
325327
id={`${props.inputId}-listbox-option-${optionData.id}`}
328+
key={`menu-subtitle-${optionData.id}`}
326329
className={classNames(
327330
'slds-media slds-listbox__option',
328331
'slds-listbox__option_entity slds-listbox__option_has-meta',
@@ -375,6 +378,7 @@ const Menu = (props) => {
375378
aria-selected={active}
376379
{...disabledProps}
377380
id={`${props.inputId}-listbox-option-${optionData.id}`}
381+
key={`menu-checkbox-${optionData.id}`}
378382
className={classNames(
379383
'slds-media slds-listbox__option',
380384
' slds-listbox__option_plain slds-media_small slds-media_center',
@@ -451,7 +455,7 @@ const Menu = (props) => {
451455
item = React.cloneElement(
452456
props.tooltipMenuItemDisabled,
453457
tooltipProps,
454-
menuItem[props.variant]
458+
React.cloneElement(menuItem[props.variant], { tabIndex: 0 })
455459
);
456460
} else {
457461
item = menuItem[props.variant];

‎components/component-docs.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -6001,7 +6001,7 @@
60016001
"name": "func"
60026002
},
60036003
"required": false,
6004-
"description": "Date formatting function that formats the `value` prop (`value` is an ECMAScript `Date()` object) before rendering the `input` value. Please use an external library such as [MomentJS](https://github.com/moment/moment/) for date formatting and internationalization. _Tested with snapshot testing._\nThe default `formatter` function is:\n```\nformatter(date) {\n return date\n ? `${date.getMonth() + 1}/${date.getDate()}/${date.getFullYear()}`\n : '';\n}\n```",
6004+
"description": "Date formatting function that formats the `value` prop (`value` is an ECMAScript `Date()` object) and returns a string to be rendered as the `input` value. Please use an external library such as [MomentJS](https://github.com/moment/moment/) for date formatting and internationalization. _Tested with snapshot testing._\nThe default `formatter` function is:\n```\nformatter(date) {\n return date\n ? `${date.getMonth() + 1}/${date.getDate()}/${date.getFullYear()}`\n : '';\n}\n```",
60056005
"defaultValue": {
60066006
"value": "function(date) {\n return date\n ? `${date.getMonth() + 1}/${date.getDate()}/${date.getFullYear()}`\n : '';\n}",
60076007
"computed": false
@@ -6158,7 +6158,7 @@
61586158
"name": "func"
61596159
},
61606160
"required": false,
6161-
"description": "Custom function to parse date string from the `input` value and returns a `Date` object. Please use an external library such as [MomentJS](https://github.com/moment/moment/) for date parsing and internationalization. The default `parser` passes the input value to ECMAScript `Date()` and _prays_ for a miracle. **Do not use the default parsing function in production.** _Tested with snapshot testing._\nThe default `parser function is:\n```\nparser(str) {\n return new Date(str);\n}\n```",
6161+
"description": "Custom function to parse date string from the `input` value, which must return an ECMAScript `Date()` object. Please use an external library such as [MomentJS](https://github.com/moment/moment/) for date parsing and internationalization. The default `parser` passes the input value to ECMAScript `Date()` and _prays_ for a miracle. **Do not use the default parsing function in production.** _Tested with snapshot testing._\nThe default `parser function is:\n```\nparser(str) {\n return new Date(str);\n}\n```",
61626162
"defaultValue": {
61636163
"value": "function(str) {\n lowPriorityWarning(\n false,\n `Please use an external library for date parsing and internationalization like MomentJS (https://github.com/moment/moment/) instead of the default parser.`\n );\n return new Date(str);\n}",
61646164
"computed": false

‎components/data-table/__docs__/__snapshots__/storybook-stories.storyshot

+5-4
Original file line numberDiff line numberDiff line change
@@ -5004,7 +5004,6 @@ exports[`DOM snapshots SLDSDataTable Fixed Header 1`] = `
50045004
<input
50055005
checked={false}
50065006
id="DataTableExample-FixedHeaders-SLDSDataTableHead-SelectAll-fixed-header"
5007-
name={false}
50085007
onChange={[Function]}
50095008
type="checkbox"
50105009
/>
@@ -8029,7 +8028,6 @@ exports[`DOM snapshots SLDSDataTable Fixed Header Horizontal Scrolling 1`] = `
80298028
<input
80308029
checked={false}
80318030
id="DataTableExample-FixedHeaders-SLDSDataTableHead-SelectAll-fixed-header"
8032-
name={false}
80338031
onChange={[Function]}
80348032
type="checkbox"
80358033
/>
@@ -11014,7 +11012,11 @@ exports[`DOM snapshots SLDSDataTable Joined with Page Header 1`] = `
1101411012
xlinkHref="/assets/icons/standard-sprite/svg/symbols.svg#lead"
1101511013
/>
1101611014
</svg>
11017-
11015+
<span
11016+
className="slds-assistive-text"
11017+
>
11018+
User
11019+
</span>
1101811020
</span>
1101911021

1102011022
</div>
@@ -11422,7 +11424,6 @@ exports[`DOM snapshots SLDSDataTable Joined with Page Header 1`] = `
1142211424
<input
1142311425
checked={false}
1142411426
id="DataTableExample-FixedHeaders-SLDSDataTableHead-SelectAll-fixed-header"
11425-
name={false}
1142611427
onChange={[Function]}
1142711428
type="checkbox"
1142811429
/>

‎components/data-table/__examples__/joined-with-page-header.jsx

+8-3
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import DataTableCell from '~/components/data-table/cell';
88
import DataTableRowActions from '~/components/data-table/row-actions';
99
import Dropdown from '~/components/menu-dropdown';
1010
import DropdownTrigger from '~/components/menu-dropdown/button-trigger';
11+
import Icon from '~/components/icon';
1112
import IconSettings from '~/components/icon-settings';
1213
import PageHeader from '~/components/page-header';
1314
import PageHeaderControl from '~/components/page-header/control';
@@ -331,9 +332,13 @@ class Example extends React.Component {
331332
</h3>
332333
<PageHeader
333334
onRenderActions={actions}
334-
iconAssistiveText="User"
335-
iconCategory="standard"
336-
iconName="lead"
335+
icon={
336+
<Icon
337+
assistiveText={{ label: 'User' }}
338+
category="standard"
339+
name="lead"
340+
/>
341+
}
337342
info="10 items • sorted by name"
338343
joined
339344
label="Leads"

‎components/data-table/private/head.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ class DataTableHead extends React.Component {
141141
indeterminate={this.props.indeterminateSelected}
142142
id={`${this.props.id}-${idSuffix}`}
143143
// There is a checkbox for user interaction and a checkbox for positioning. ariaHidden is for the checkbox for positioning and it should be removed from the accessibility tree.
144-
name={!ariaHidden && 'SelectAll'}
144+
name={!ariaHidden ? 'SelectAll' : undefined}
145145
onChange={this.props.onToggleAll}
146146
/>
147147
</div>

0 commit comments

Comments
 (0)