Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing name & type in Nargo.toml #3

Closed
mozrt2 opened this issue Aug 13, 2023 · 4 comments
Closed

Missing name & type in Nargo.toml #3

mozrt2 opened this issue Aug 13, 2023 · 4 comments

Comments

@mozrt2
Copy link

mozrt2 commented Aug 13, 2023

Hi there,

I just tried to get started with noir-by-example but was getting the following error when using nargo test --show-output: Error: Missing 'name' field in /noir-by-example/circuits/examples/hello-world/Nargo.toml

I believe this is related to the latest version of Noir (I am using 0.9.0) requiring a name and type in the Nargo.toml files. When adding the below to the Nargo.toml in the hello-world example, the test passes without error:

name = "hello world"
type = "bin"

I am planning to go through all examples over the coming days and could then make a PR with this adjustment for all examples. Just wanted to already highlight it here in case anyone else encounters the same problem.

@sambarnes
Copy link
Owner

@mozrt2 yoo ✌️ thanks for the heads up on this! i've been away from noir for a sec so didnt see this til now

i've updated all the basic examples with the requirements in latest nightly nargo

but looks like some tests for the two gadgets pages are failing on latest version -- if you wanted to take a stab at those still? otherwise i'll probs get to it eventually

@sambarnes
Copy link
Owner

see #4

@mozrt2
Copy link
Author

mozrt2 commented Sep 9, 2023

Hi @sambarnes - great, thanks for fixing these! I'm currently swamped with other stuff so not sure I'll be able to look into this issue - will let you know if I do end up finding some time!

@sambarnes
Copy link
Owner

@mozrt2 no worries at all :) just didn't wanna rug the contribution entirely if ya were still interested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants