Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Manifest Parsing Strategy #606

Closed
5 tasks
joncameron opened this issue Jul 30, 2024 · 2 comments
Closed
5 tasks

Change Manifest Parsing Strategy #606

joncameron opened this issue Jul 30, 2024 · 2 comments
Assignees

Comments

@joncameron
Copy link
Contributor

joncameron commented Jul 30, 2024

Description

Moving manifest parsing to a central location so it can be managed with state that doesn't require components to do unnecessary processing.

This can be done before or in parallel with the state management investigation (#605).

These changes will require thorough testing. Most of it could be handled in unit testing; tests will most likely need to be added as parsing is changed. This should not change functionality, but with changing the parsing strategy it should still be expected that all the fields are still coming to the right place for consumption by Ramp components.

Done Looks Like

  • Bring manifest parsing code into a single place
  • Manifests only need to be read and parsed once
  • Create a single data structure that can be used to represent manifest data across components
  • Remove unnecessary state values or duplicates from different components
  • Test across Ramp components to ensure they're populating data correctly from manifest data

QA

  • Test this alongside Ramp Investigate State Management Alternatives #605, as both introduce major infrastructure changes to Ramp
  • Test functionality across all Ramp components: media player, transcripts, files, metadata, structure, playlists, auto-play, markers
@elynema
Copy link

elynema commented Aug 14, 2024

Dananji is testing vault and manifesto for parsing manifests. Vault errs when we have inaccessible items with no ID.

@joncameron
Copy link
Contributor Author

👍
I created #656, a bug that looks like it may be with the demo site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants