Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cyclical dependence of SectionHeading component #648

Open
8 tasks
Dananji opened this issue Sep 20, 2024 · 0 comments
Open
8 tasks

Remove cyclical dependence of SectionHeading component #648

Dananji opened this issue Sep 20, 2024 · 0 comments
Labels
structured_nav Improvements/fixes in structured nav

Comments

@Dananji
Copy link
Collaborator

Dananji commented Sep 20, 2024

Description

#643 (review)

Not in scope of this PR but when looking through it I thought the cyclical dependence of SectionHeading on List and List on SectionHeading is confusing. I wonder if having an abstract component with subclasses might help scope and conceptualize the different uses of the two components.

Done Looks Like

@Dananji Dananji added the structured_nav Improvements/fixes in structured nav label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
structured_nav Improvements/fixes in structured nav
Projects
None yet
Development

No branches or pull requests

1 participant