Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize new built-in support for complex numbers in netCDF #381

Open
ryancoe opened this issue Oct 21, 2024 · 1 comment
Open

Utilize new built-in support for complex numbers in netCDF #381

ryancoe opened this issue Oct 21, 2024 · 1 comment
Labels
upstream Related to a dependency of our package

Comments

@ryancoe
Copy link
Collaborator

ryancoe commented Oct 21, 2024

I don't entirely understand all of the different packages and standards, but it appears that there's now some more built-in support within xarray for handling complex numbers in netCDF files. Here's what I've looked at so far:

Suggested action:

  1. Confirm that using the following syntax is the preferred approach and isn't going to change any minute (it seems like you may already/soon be able to do this using engine=netcdf4): da.to_netcdf("complex.nc", engine="h5netcdf", invalid_netcdf=True)
  2. Update (maybe even delete) write_netcdf and read_netcdf in core.py
@ryancoe ryancoe added the upstream Related to a dependency of our package label Oct 21, 2024
@ryancoe
Copy link
Collaborator Author

ryancoe commented Oct 24, 2024

This is really mostly a capytaine thing, I will create an issue there and close this one when I do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Related to a dependency of our package
Projects
None yet
Development

No branches or pull requests

1 participant