setup_logging does not use LOG_EXTRA in all cases

[ozancaglayan]

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

Since >= 24.6 where logging was overhauled, it is nearly impossible to recover the pre-24.6 behaviour for logging if LogRecord has additional fields. They are getting logged as extra lines when mode is debug. I managed to make it work correctly for non-debug mode.

Tried setting SANIC_LOG_EXTRA=false , doesn't seem to work as this value seems to be sometimes read but also is written by Sanic itself in sanic/logging/setup.py.

I then noticed that setup_logging has a log_extra param which is by default set using the deployment mode. But in some cases depending on how the service is run, the third parameter is also passed.

sanic/worker/serve.py:        setup_logging(
sanic/worker/serve.py-            app.state.is_debug, app.config.NO_COLOR, app.config.LOG_EXTRA
sanic/worker/serve.py-        )
sanic/worker/serve.py-

sanic/app.py-        details: https://asgi.readthedocs.io/en/latest
sanic/app.py-        """
sanic/app.py-        if scope["type"] == "lifespan":
sanic/app.py:            setup_logging(self.state.is_debug, self.config.NO_COLOR)

I think the latter should also obey the self.config.NO_COLOR parameter for consistency.

Code snippet

No response

Expected Behavior

I expect a clear way of disabling this LOG_EXTRA feature either from the environment or through other mechanisms.

How do you run Sanic?

Sanic CLI

Operating System

Linux

Sanic Version

24.12

Additional context

No response