fix: handle import(configFile) on windows regression
#2145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stipsan
changed the title
import(configFile) on windows regression
Member
Author
|
Hey @copilot can you fix the failing windows tests? |
There was a problem hiding this comment.
Pull Request Overview
This PR adds Windows support to the build and test suite by removing platform-specific test skipping and fixing Windows-specific compatibility issues.
- Removed
test.skipIf(isWindows)from all test cases to enable Windows CI testing - Fixed Windows path handling in config loading by converting absolute paths to file URLs
- Updated GitHub Actions workflow to run playground builds on both Ubuntu and Windows
- Fixed pnpm filter glob syntax in package.json scripts
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/node.test.ts | Removed Windows test skip condition to run tests on Windows |
| test/cli.test.ts | Removed Windows test skip conditions from all test cases |
| src/node/core/config/loadConfig.ts | Added Windows-compatible path-to-URL conversion for imports and error logging |
| package.json | Changed playground script glob quotes from single to double quotes for Windows compatibility |
| .github/workflows/main.yml | Added Windows to the test matrix for playground builds |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+35
to
+39
| console.error('tsx import error', error, { | ||
| configFile, | ||
| configFileUrl, | ||
| 'import.meta.url': import.meta.url, | ||
| }) |
There was a problem hiding this comment.
Debug console.error logging should be removed before merging to production. This appears to be temporary debugging code that should either be removed or replaced with a proper logger that respects the application's logging configuration.
Member
Author
|
Hey @copilot can you fix the failing windows tests? |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression in #2138 for windows