Skip to content

Commit 6891d6e

Browse files
authored
Merge pull request #122 from marcelmamula/restore-lint
collection: Update ansible-lint actions and configuration
2 parents 81edddb + d261a1b commit 6891d6e

7 files changed

Lines changed: 51 additions & 43 deletions

.ansible-lint

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,8 @@ skip_list:
3030
- no-handler
3131
# Disable jinja formatting check
3232
- jinja[spacing]
33-
34-
# Disabled skips, because they are not not required now.
35-
# - yaml[comments]
36-
# - yaml[line-length]
37-
# - no-tabs
33+
# Removing these skips would require refactoring of most roles
34+
- yaml[comments]
35+
- yaml[line-length]
36+
- no-tabs
3837
# - var-naming[no-jinja]

.github/workflows/ansible-lint-sap_hypervisor_node_preconfigure.yml

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,25 +18,28 @@ on:
1818
paths:
1919
- 'roles/sap_hypervisor_node_preconfigure/**'
2020

21+
workflow_dispatch:
22+
2123
jobs:
2224
ansible-lint:
2325
runs-on: ubuntu-latest
2426

2527
steps:
2628
- name: Check out the code
27-
uses: actions/checkout@main
29+
uses: actions/checkout@v4
2830

2931
- name: Set up Python 3
30-
uses: actions/setup-python@main
32+
uses: actions/setup-python@v5
3133
with:
32-
python-version: '3.9'
34+
python-version: '3.13'
3335

3436
- name: Install test dependencies
3537
run: |
36-
pip3 install ansible==7.5.0
37-
pip3 install ansible-compat==3.0.2
38-
pip3 install ansible-core==2.14.5
39-
pip3 install ansible-lint==6.8.6
38+
pip3 install \
39+
ansible-core~=2.18.0 \
40+
ansible~=11.0.0 \
41+
ansible-lint~=25.1.0 \
42+
ansible-compat~=25.1.0
4043
4144
- name: Run ansible-lint
4245
working-directory: /home/runner/work/community.sap_infrastructure/community.sap_infrastructure/roles/sap_hypervisor_node_preconfigure

.github/workflows/ansible-lint-sap_vm_preconfigure.yml

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,25 +18,28 @@ on:
1818
paths:
1919
- 'roles/sap_vm_preconfigure/**'
2020

21+
workflow_dispatch:
22+
2123
jobs:
2224
ansible-lint:
2325
runs-on: ubuntu-latest
2426

2527
steps:
2628
- name: Check out the code
27-
uses: actions/checkout@main
29+
uses: actions/checkout@v4
2830

2931
- name: Set up Python 3
30-
uses: actions/setup-python@main
32+
uses: actions/setup-python@v5
3133
with:
32-
python-version: '3.12'
34+
python-version: '3.13'
3335

3436
- name: Install test dependencies
3537
run: |
36-
pip3 install ansible==9.1.0
37-
pip3 install ansible-compat==4.1.10
38-
pip3 install ansible-core==2.16.2
39-
pip3 install ansible-lint==6.22.1
38+
pip3 install \
39+
ansible-core~=2.18.0 \
40+
ansible~=11.0.0 \
41+
ansible-lint~=25.1.0 \
42+
ansible-compat~=25.1.0
4043
4144
- name: Run ansible-lint
4245
working-directory: /home/runner/work/community.sap_infrastructure/community.sap_infrastructure/roles/sap_vm_preconfigure

.github/workflows/ansible-lint-sap_vm_provision.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,16 @@ jobs:
3131
- name: Set up Python 3
3232
uses: actions/setup-python@v5
3333
with:
34-
python-version: '3.12'
34+
python-version: '3.13'
3535

3636
- name: Install test dependencies
3737
run: |
38-
pip3 install ansible==9.1.0
39-
pip3 install ansible-compat==4.1.10
40-
pip3 install ansible-core==2.16.2
41-
pip3 install ansible-lint==6.22.1
42-
pip3 install jmespath==1.0.1
38+
pip3 install \
39+
ansible-core~=2.18.0 \
40+
ansible~=11.0.0 \
41+
ansible-lint~=25.1.0 \
42+
ansible-compat~=25.1.0 \
43+
jmespath~=1.0.0
4344
4445
- name: Install dependencies for Ansible
4546
run: ansible-galaxy collection install -r /home/runner/work/community.sap_infrastructure/community.sap_infrastructure/requirements.yml

.github/workflows/ansible-lint-sap_vm_temp_vip.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,15 @@ jobs:
3131
- name: Set up Python 3
3232
uses: actions/setup-python@v5
3333
with:
34-
python-version: '3.12'
34+
python-version: '3.13'
3535

3636
- name: Install test dependencies
3737
run: |
38-
pip3 install ansible==9.1.0
39-
pip3 install ansible-compat==4.1.10
40-
pip3 install ansible-core==2.16.2
41-
pip3 install ansible-lint==6.22.1
38+
pip3 install \
39+
ansible-core~=2.18.0 \
40+
ansible~=11.0.0 \
41+
ansible-lint~=25.1.0 \
42+
ansible-compat~=25.1.0
4243
4344
- name: Run ansible-lint
4445
working-directory: /home/runner/work/community.sap_infrastructure/community.sap_infrastructure/roles/sap_vm_temp_vip

.github/workflows/ansible-lint-sap_vm_verify.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,15 @@ jobs:
3131
- name: Set up Python 3
3232
uses: actions/setup-python@v5
3333
with:
34-
python-version: '3.12'
34+
python-version: '3.13'
3535

3636
- name: Install test dependencies
3737
run: |
38-
pip3 install ansible==9.1.0
39-
pip3 install ansible-compat==4.1.10
40-
pip3 install ansible-core==2.16.2
41-
pip3 install ansible-lint==6.22.1
42-
pip3 install jmespath==1.0.1
38+
pip3 install \
39+
ansible-core~=2.18.0 \
40+
ansible~=11.0.0 \
41+
ansible-lint~=25.1.0 \
42+
ansible-compat~=25.1.0
4343
4444
- name: Run ansible-lint
4545
working-directory: /home/runner/work/community.sap_infrastructure/community.sap_infrastructure/roles/sap_vm_verify

.github/workflows/ansible-lint.yml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,16 @@ jobs:
2121
- name: Set up Python 3
2222
uses: actions/setup-python@v5
2323
with:
24-
python-version: '3.12'
24+
python-version: '3.13'
2525

26-
- name: Install dependencies for Python
26+
- name: Install test dependencies
2727
run: |
28-
pip3 install ansible==9.1.0
29-
pip3 install ansible-compat==4.1.10
30-
pip3 install ansible-core==2.16.2
31-
pip3 install ansible-lint==6.22.1
32-
pip3 install jmespath==1.0.1
28+
pip3 install \
29+
ansible-core~=2.18.0 \
30+
ansible~=11.0.0 \
31+
ansible-lint~=25.1.0 \
32+
ansible-compat~=25.1.0 \
33+
jmespath~=1.0.0
3334
3435
- name: Install dependencies for Ansible
3536
run: ansible-galaxy collection install -r /home/runner/work/community.sap_infrastructure/community.sap_infrastructure/requirements.yml

0 commit comments

Comments
 (0)