Skip to content

Commit fdbebb9

Browse files
authored
Merge pull request #685 from adpi2/fix-launch-args
Fix parsing launch arguments
2 parents 32f4b67 + d691150 commit fdbebb9

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

modules/core/src/main/scala/ch/epfl/scala/debugadapter/internal/DebugSession.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ private[debugadapter] final class DebugSession private (
153153
val command = Command.parse(request.command)
154154
// the launch args sent by Metals do not conform to the LaunchArgument of java-debug
155155
// here we parse to PartialLaunchArguments which only contains noDebug
156-
val launchArgs = JsonUtils.fromJson(request.arguments, classOf[PartialLaunchArguments])
156+
val launchArgs = JsonUtils.fromJson(request.arguments, classOf[ScalaLaunchArguments])
157157
val tools =
158158
if (launchArgs.noDebug) DebugTools.none(logger)
159159
else DebugTools(debuggee, resolver, logger)
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package ch.epfl.scala.debugadapter.internal;
22

3-
import com.microsoft.java.debug.core.protocol.Requests.LaunchArguments
43
import ch.epfl.scala.debugadapter.StepFiltersConfig
54

6-
case class PartialLaunchArguments(
5+
case class ScalaLaunchArguments(
6+
noDebug: Boolean,
77
scalaStepFilters: StepFiltersConfig
8-
) extends LaunchArguments
8+
)

modules/tests/src/main/scala/ch/epfl/scala/debugadapter/testfmk/TestingDebugClient.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import ch.epfl.scala.debugadapter.Logger
2323
import scala.collection.concurrent.TrieMap
2424
import scala.concurrent.Future
2525
import scala.concurrent.Await
26-
import ch.epfl.scala.debugadapter.internal.PartialLaunchArguments
26+
import ch.epfl.scala.debugadapter.internal.ScalaLaunchArguments
2727
import ch.epfl.scala.debugadapter.StepFiltersConfig
2828

2929
class TestingDebugClient(socket: Socket, logger: Logger)(implicit
@@ -53,7 +53,7 @@ class TestingDebugClient(socket: Socket, logger: Logger)(implicit
5353
timeout: Duration = defaultTimeout(16.seconds),
5454
stepFilters: StepFiltersConfig = null
5555
): Messages.Response = {
56-
val request = createRequest(Command.LAUNCH, new PartialLaunchArguments(stepFilters))
56+
val request = createRequest(Command.LAUNCH, new ScalaLaunchArguments(noDebug = false, stepFilters))
5757

5858
Await.result(sendRequest(request), timeout)
5959
}

0 commit comments

Comments
 (0)