tests(instance): update cassettes

Author: Laure-di

internal/namespaces/instance/v1/custom.go

@@ -52,6 +52,8 @@ func GetCommands() *core.Commands {
 	cmds.MustFind("instance", "server", "list").Override(serverListBuilder)
 	cmds.MustFind("instance", "server", "update").Override(serverUpdateBuilder)
 	cmds.MustFind("instance", "server", "get").Override(serverGetBuilder)
+	cmds.MustFind("instance", "server", "attach-volume").Override(serverAttachVolumeBuilder)
+	cmds.MustFind("instance", "server", "detach-volume").Override(serverDetachVolumeBuilder)
 
 	cmds.Merge(core.NewCommands(
 		serverBackupCommand(),

internal/namespaces/instance/v1/custom_server.go

@@ -389,6 +389,35 @@ func volumeIsFromSBS(api *block.API, zone scw.Zone, volumeID string) bool {
 	return err == nil
 }
 
+func serverAttachVolumeBuilder(c *core.Command) *core.Command {
+	c.Interceptor = func(ctx context.Context, argsI any, runner core.CommandRunner) (any, error) {
+		request := argsI.(*instance.AttachServerVolumeRequest)
+		api := instance.NewAPI(core.ExtractClient(ctx))
+
+		return api.AttachVolume(&instance.AttachVolumeRequest{
+			Zone:     request.Zone,
+			VolumeID: request.VolumeID,
+			ServerID: request.ServerID,
+		})
+	}
+
+	return c
+}
+
+func serverDetachVolumeBuilder(c *core.Command) *core.Command {
+	c.Interceptor = func(ctx context.Context, argsI any, runner core.CommandRunner) (any, error) {
+		request := argsI.(*instance.DetachServerVolumeRequest)
+		api := instance.NewAPI(core.ExtractClient(ctx))
+
+		return api.DetachVolume(&instance.DetachVolumeRequest{
+			Zone:     request.Zone,
+			VolumeID: request.VolumeID,
+		})
+	}
+
+	return c
+}
+
 func serverGetBuilder(c *core.Command) *core.Command {
 	// This method is here as a proof of concept before we find the correct way to implement it at larger scale
 	c.ArgSpecs.GetPositionalArg().AutoCompleteFunc = func(ctx context.Context, prefix string, request any) core.AutocompleteSuggestions {

internal/namespaces/instance/v1/custom_server_test.go

@@ -99,12 +99,12 @@ func Test_ServerVolumeUpdate(t *testing.T) {
 			Check: func(t *testing.T, ctx *core.CheckFuncCtx) {
 				t.Helper()
 				require.NoError(t, ctx.Err)
-				resp := testhelpers.Value[*instanceSDK.DetachServerVolumeResponse](t, ctx.Result)
+				resp := testhelpers.Value[*instanceSDK.DetachVolumeResponse](t, ctx.Result)
 				assert.NotZero(t, resp.Server.Volumes["0"])
 				assert.Nil(t, resp.Server.Volumes["1"])
 				assert.Len(
 					t,
-					ctx.Result.(*instanceSDK.DetachServerVolumeResponse).Server.Volumes,
+					ctx.Result.(*instanceSDK.DetachVolumeResponse).Server.Volumes,
 					1,
 				)
 			},
@@ -165,6 +165,7 @@ func Test_ServerUpdateCustom(t *testing.T) {
 				assert.NotNil(t, resp.Server)
 				assert.NotNil(t, resp.Server.PublicIP)
 				assert.Equal(t, ip.Address, resp.Server.PublicIP.Address)
+
 			},
 			core.TestCheckExitCode(0),
 		),

internal/namespaces/instance/v1/testdata/test-server-volume-update-attach-invalid-volume-uuid.cassette.yaml

@@ -1,24 +1,11 @@
 🎲🎲🎲 EXIT CODE: 1 🎲🎲🎲
 🟥🟥🟥 STDERR️️ 🟥🟥🟥️
-Invalid arguments 'volume_id'
-
-Details:
-- 'volume_id' does not respect constraints
-
-Hint:
-Volume 11111111-1111-1111-1111-111111111111 is not attached to this server
+Cannot find resource 'volume' with ID '11111111-1111-1111-1111-111111111111'
 🟥🟥🟥 JSON STDERR 🟥🟥🟥
 {
-  "message": "invalid arguments 'volume_id'",
+  "message": "cannot find resource 'volume' with ID '11111111-1111-1111-1111-111111111111'",
   "error": {
-    "details": [
-      {
-        "argument_name": "volume_id",
-        "reason": "constraint",
-        "help_message": "Volume 11111111-1111-1111-1111-111111111111 is not attached to this server"
-      }
-    ]
-  },
-  "details": "- 'volume_id' does not respect constraints",
-  "hint": "Volume 11111111-1111-1111-1111-111111111111 is not attached to this server"
+    "resource": "volume",
+    "resource_id": "11111111-1111-1111-1111-111111111111"
+  }
 }