Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changesets-renovate includes private (not published) packages #1716

Open
moltar opened this issue Dec 8, 2023 · 0 comments
Open

changesets-renovate includes private (not published) packages #1716

moltar opened this issue Dec 8, 2023 · 0 comments

Comments

@moltar
Copy link

moltar commented Dec 8, 2023

Describe the bug

The script that generates the changeset manifest will include a private package in the list.

Changesets will then fail to run with:

🦋 error Error: "renovate-c2f96a3" changeset mentions a release for a package "@foo/bar" but such a package could not be found.

To Reproduce

  1. Touch a private file.
  2. Run the script.
  3. Observe that Markdown changeset includes the private package

Expected behavior

Do not include private packates.

Screenshots

N/A

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

This can often happen in a monorepo context, where the root packages (monorepo root) receives an updated dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant