From 2faa742f08b5e347aee4e364c58f7a995fbf4295 Mon Sep 17 00:00:00 2001
From: sylvain senechal <senechalsylvain.dev@gmail.com>
Date: Tue, 22 Jul 2025 11:02:20 +0200
Subject: [PATCH] fix concurrent mpu duplicate objects bug

Issue : ARSN-513
---
 lib/storage/metadata/mongoclient/MongoClientInterface.ts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/lib/storage/metadata/mongoclient/MongoClientInterface.ts b/lib/storage/metadata/mongoclient/MongoClientInterface.ts
index 87f180e01..3fd845e60 100644
--- a/lib/storage/metadata/mongoclient/MongoClientInterface.ts
+++ b/lib/storage/metadata/mongoclient/MongoClientInterface.ts
@@ -139,6 +139,7 @@ export type ObjectMDOperationParams = {
     needOplogUpdate: boolean,
     originOp: string,
     doesNotNeedOpogUpdate?: boolean,
+    preventConcurrentCompletion?: boolean,
     conditions: any,
 };
 
@@ -1200,6 +1201,9 @@ class MongoClientInterface {
      * @param {string} params.vFormat - object key format.
      * @param {boolean} params.needOplogUpdate - If true, the object is directly put into the collection
      * with updating the operation log.
+     * @param {boolean} params.preventConcurrentCompletion - If true, the object is only created if 
+     * completeInProgress is not already set to true. Fix this concurrent completeMultipartUpload issue : 
+     * https://scality.atlassian.net/jira/software/c/projects/OS/boards/268?selectedIssue=CLDSRV-687
      * @param {Object} log - The logger to use.
      * @param {Function} cb - The callback function to call when the operation is complete. It is called with an error
      * if there is an issue with the operation.
@@ -1220,6 +1224,9 @@ class MongoClientInterface {
         }
         const key = formatMasterKey(objName, params.vFormat);
         const putFilter = { _id: key };
+        if (params?.preventConcurrentCompletion) {
+            putFilter['value.completeInProgress'] = { $ne: true };
+        }
         return collection.updateOne(putFilter, {
             $set: {
                 _id: key,