added test for replication that should not happen

Issue : ZENKO-5057

Author: SylvainSenechal

tests/ctst/features/crrReplicationS3utils.feature

@@ -2,15 +2,24 @@ Feature: Replication
     This feature tests replication using the script crrExistingObjects.js from S3utils,
     that replicates objects created before the replication was enabled on source the bucket.
 
+    @2.12.0
+    @PreMerge
+    @ReplicationTest
+    Scenario Outline: Objects created before setting up replication should not be replicated automatically
+        Given an existing bucket "source-bucket-0" "with" versioning, "without" ObjectLock "without" retention mode
+        And an object "source-object-1" that "exists"
+        And a replication configuration to "awsbackendmismatch" location
+        Then the object replication should "never happen" within 30 seconds
+
     @2.12.0
     @PreMerge
     @ReplicationTest
     Scenario Outline: Replicate objects created before creating the replication rule
-        Given an existing bucket "source-bucket" "with" versioning, "without" ObjectLock "without" retention mode
+        Given an existing bucket "source-bucket-1" "with" versioning, "without" ObjectLock "without" retention mode
         And an object "source-object-1" that "exists"
         And a replication configuration to "awsbackendmismatch" location
         When the job to replicate existing objects with status "NEW" is executed
-        Then the object should eventually "be" replicated
+        Then the object replication should "succeed" within 300 seconds
         And the replicated object should be the same as the source object
 
     @2.12.0
@@ -22,8 +31,8 @@ Feature: Replication
         And a replication configuration to "awsbackendreplicationctstfail" location
         And a deleted destination bucket on that location
         And an object "source-object-2" that "exists"
-        Then the object should eventually "fail to be" replicated
+        Then the object replication should "fail" within 500 seconds
         When the destination bucket on the location is created again
         And the job to replicate existing objects with status "FAILED" is executed
-        Then the object should eventually "be" replicated
+        Then the object replication should "succeed" within 300 seconds
         And the replicated object should be the same as the source object

tests/ctst/package.json

@@ -18,8 +18,7 @@
     "prometheus-query": "^3.4.0",
     "proper-lockfile": "^4.1.2",
     "qs": "^6.13.0",
-    "scubaclient": "git+https://github.com/scality/scubaclient#^1.1.2",
-    "uuid": "^11.1.0"
+    "scubaclient": "git+https://github.com/scality/scubaclient#^1.1.2"
   },
   "devDependencies": {
     "@aws-sdk/client-iam": "^3.582.0",

tests/ctst/steps/replication.ts

@@ -89,13 +89,16 @@ When('the job to replicate existing objects with status {string} is executed',
         await createAndRunPod(this, podManifest);
     });
 
-Then('the object should eventually {string} replicated', { timeout: 360_000 },
-    async function (this: Zenko, replicate: 'be' | 'fail to be') {
+Then('the object replication should {string} within {int} seconds', { timeout: 600_000 },
+    async function (
+        this: Zenko,
+        expectedOutcome: 'succeed' | 'fail' | 'never happen',
+        replicationTimeout: number
+    ) {
         const objectName = this.getSaved<string>('objectName');
         const bucketSource = this.getSaved<string>('bucketName');
         const startTime = Date.now();
-        const replicationTimeoutMs = 300_000;
-        while (Date.now() - startTime < replicationTimeoutMs) {
+        while (Date.now() - startTime < replicationTimeout * 1000) {
             await new Promise(resolve => setTimeout(resolve, 3000));
 
             const response = await headObject(this, objectName, bucketSource);
@@ -112,26 +115,30 @@ Then('the object should eventually {string} replicated', { timeout: 360_000 },
             assert(parsed.ok);
             const replicationStatus = parsed.result?.ReplicationStatus;
 
-            if (replicate === 'be') {
-                assert.notStrictEqual(replicationStatus, 'FAILED', `replication failed for object ${objectName}`);
-                if (replicationStatus === 'COMPLETED') {
-                    return;
-                }
-            } else if (replicate === 'fail to be') {
-                assert.notStrictEqual(
-                    replicationStatus,
-                    'COMPLETED',
-                    `expected replication to fail for object ${objectName}`
-                );
-                if (replicationStatus === 'FAILED') {
-                    return;
-                }
-            }
-            if (replicationStatus === 'PENDING' || replicationStatus === 'PROCESSING') {
+            switch (replicationStatus) {
+            case 'PENDING':
+            case 'PROCESSING':
+                assert.notStrictEqual(expectedOutcome, 'never happen', 
+                    `replication status is ${replicationStatus}, but expected to never happen`);
                 continue;
+            case 'COMPLETED':
+                assert.strictEqual(expectedOutcome, 'succeed', 
+                    `replication is completed, but expected outcome was '${expectedOutcome}'`);
+                return;
+            case 'FAILED':
+                assert.strictEqual(expectedOutcome, 'fail', 
+                    `replication is failed, but expected outcome was '${expectedOutcome}'`);
+                return;
+            case undefined:
+                // If we don't expect a replication to happen, the replication status should remain undefined
+                assert.strictEqual(expectedOutcome, 'never happen',
+                    `got undefined replication status for expected outcome '${expectedOutcome}'`);
+                return;
+            default:
+                throw new Error(`Unexpected replication status: ${replicationStatus}`);
             }
         }
-        assert.fail(`Timeout: Object '${objectName}' is still pending/processing after timeout`);
+        assert.fail(`Timeout: Object '${objectName}' is still in pending/processing state after timeout`);
     });
 
 Then(

tests/ctst/yarn.lock

@@ -4664,11 +4664,6 @@ [email protected], uuid@^9.0.1:
   resolved "https://registry.yarnpkg.com/uuid/-/uuid-9.0.1.tgz#e188d4c8853cc722220392c424cd637f32293f30"
   integrity sha512-b+1eJOlsR9K8HJpow9Ok3fiWOWSIcIzXodvv0rQjVoOVNpWMpxf1wZNpt4y9h10odCNrqnYp1OBzRktckBe3sA==
 
-uuid@^11.1.0:
-  version "11.1.0"
-  resolved "https://registry.yarnpkg.com/uuid/-/uuid-11.1.0.tgz#9549028be1753bb934fc96e2bca09bb4105ae912"
-  integrity sha512-0/A9rDy9P7cJ+8w1c9WD9V//9Wj15Ce2MPz8Ri6032usz+NfePxx5AcN3bN+r6ZL6jEo066/yNYB3tn4pQEx+A==
-
 uuid@^3.3.2:
   version "3.4.0"
   resolved "https://registry.yarnpkg.com/uuid/-/uuid-3.4.0.tgz#b23e4358afa8a202fe7a100af1f5f883f02007ee"