Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render 3-shards mongodb manifests #1845

Open
wants to merge 4 commits into
base: development/2.7
Choose a base branch
from

Conversation

rahulreddy
Copy link
Collaborator

@rahulreddy rahulreddy commented Apr 14, 2023

This does not change the current default of deploying 1 shard by default. The provided manifests allow enabling 3 shards at some customers especially who will be migrating from Zenko 1.2

@bert-e
Copy link
Contributor

bert-e commented Apr 14, 2023

Hello rahulreddy,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Apr 14, 2023

Incorrect fix version

The Fix Version/s in issue ZENKO-4560 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.7.3

Please check the Fix Version/s of ZENKO-4560, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Apr 14, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@rahulreddy rahulreddy force-pushed the improvement/ZENKO-4560-multiple-shards branch from 7968b21 to b57666d Compare April 16, 2023 17:14
@rahulreddy rahulreddy changed the base branch from development/2.7 to bugfix/ZENKO-4527-fix-mongodb-deployment-and-upgrade-charts-fix April 16, 2023 17:14
@williamlardier williamlardier force-pushed the bugfix/ZENKO-4527-fix-mongodb-deployment-and-upgrade-charts-fix branch 2 times, most recently from 1160806 to bd54acc Compare April 18, 2023 06:44
Comment on lines +377 to +379
matchLabels:
shard: '{{ $i }}'
{{ toYaml $.Values.shardsvr.persistence.selector.matchLabels | indent 12 }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this goes into a patch file as wel?

Comment on lines +40 to +41
MONGODB_SHARDED_SINGLE_NODE_THREE_SHARDS_PATH=${ISO_ROOT}/deploy/mongodb-sharded-1-node-3-shards.yaml
MONGODB_SHARDED_THREE_NODE_THREE_SHARDS_PATH=${ISO_ROOT}/deploy/mongodb-sharded-3-nodes-3-shards.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am interested in having a bit more context, this will create two new yaml files for MongoDB, each containing multiple resources, right? But I am not able to see where it is used in https://github.com/scality/artesca/pull/1721/files#diff-9f3a8c4af71c5060627586aa78119e38ab963af820e4b554b5d204c369f8534cR28 (more specifically, how the nShards is linked at install and upgrade time).

I am asking because my PR to handle mongodb upgrade must also handle this case, but I do see logic in the Zenko.py file still relying on only one shard (like in https://github.com/scality/artesca/blob/e16707350054fbfa6980131206358ff57d4075c6/installer/artesca_installer/salt/_modules/zenko.py#L158), am I missing something?

@williamlardier williamlardier force-pushed the bugfix/ZENKO-4527-fix-mongodb-deployment-and-upgrade-charts-fix branch from bd54acc to e19bc38 Compare April 18, 2023 09:12
Base automatically changed from bugfix/ZENKO-4527-fix-mongodb-deployment-and-upgrade-charts-fix to development/2.7 April 18, 2023 11:44
@bert-e
Copy link
Contributor

bert-e commented Apr 18, 2023

Conflict

There is a conflict between your branch improvement/ZENKO-4560-multiple-shards and the
destination branch development/2.7.

Please resolve the conflict on the feature branch (improvement/ZENKO-4560-multiple-shards).

git fetch && \
git checkout origin/improvement/ZENKO-4560-multiple-shards && \
git merge origin/development/2.7

Resolve merge conflicts and commit

git push origin HEAD:improvement/ZENKO-4560-multiple-shards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants