-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render 3-shards mongodb manifests #1845
base: development/2.7
Are you sure you want to change the base?
Render 3-shards mongodb manifests #1845
Conversation
Hello rahulreddy,My role is to assist you with the merge of this Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
7968b21
to
b57666d
Compare
1160806
to
bd54acc
Compare
matchLabels: | ||
shard: '{{ $i }}' | ||
{{ toYaml $.Values.shardsvr.persistence.selector.matchLabels | indent 12 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this goes into a patch file as wel?
MONGODB_SHARDED_SINGLE_NODE_THREE_SHARDS_PATH=${ISO_ROOT}/deploy/mongodb-sharded-1-node-3-shards.yaml | ||
MONGODB_SHARDED_THREE_NODE_THREE_SHARDS_PATH=${ISO_ROOT}/deploy/mongodb-sharded-3-nodes-3-shards.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am interested in having a bit more context, this will create two new yaml files for MongoDB, each containing multiple resources, right? But I am not able to see where it is used in https://github.com/scality/artesca/pull/1721/files#diff-9f3a8c4af71c5060627586aa78119e38ab963af820e4b554b5d204c369f8534cR28 (more specifically, how the nShards is linked at install and upgrade time).
I am asking because my PR to handle mongodb upgrade must also handle this case, but I do see logic in the Zenko.py file still relying on only one shard (like in https://github.com/scality/artesca/blob/e16707350054fbfa6980131206358ff57d4075c6/installer/artesca_installer/salt/_modules/zenko.py#L158), am I missing something?
bd54acc
to
e19bc38
Compare
ConflictThere is a conflict between your branch Please resolve the conflict on the feature branch ( git fetch && \
git checkout origin/improvement/ZENKO-4560-multiple-shards && \
git merge origin/development/2.7 Resolve merge conflicts and commit git push origin HEAD:improvement/ZENKO-4560-multiple-shards |
This does not change the current default of deploying 1 shard by default. The provided manifests allow enabling 3 shards at some customers especially who will be migrating from Zenko 1.2