-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OOB versioning suspended tests #2194
base: development/2.11
Are you sure you want to change the base?
Conversation
Hello kerkesni,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
], done)); | ||
afterEach(function (done) { | ||
async.series([ | ||
next => ringS3CUtils.deleteAllVersions( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even if the location is created before, since we delete here we should also create the objects here : so the test may be (re)played multiple times...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Putting the objects is not something we can do in this case. The whole reason behind putting the objects before the location gets created is to have a specific type of null version that doesn't have an internal version id, this type of object can only be created when the bucket is non versioned which cannot happen once versioning gets enabled on it.
I want to avoid having to create the location mid tests for flakiness reasons which is why i went with this approach.
Issue: ZENKO-4330