Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/zenko 4950 mongodb v7.0 #2196

Open
wants to merge 4 commits into
base: development/2.11
Choose a base branch
from
Open

Improvement/zenko 4950 mongodb v7.0 #2196

wants to merge 4 commits into from

Conversation

benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented Feb 24, 2025 •
edited by jira bot
Loading

Issue: ZENKO-4950

Note to reviewers: the version will be bumped once Issue: ZENKO-4975 merged
Note 2: the failing docs will be fixed once the branch rebased on 2.11 post the merge above that has the fix

@bert-e
Copy link
Contributor

bert-e commented Feb 24, 2025

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@benzekrimaha benzekrimaha force-pushed the improvement/ZENKO-4950-mongodb-v7.0 branch from 5cb819e to c4bf74b Compare February 25, 2025 14:21
@benzekrimaha benzekrimaha force-pushed the improvement/ZENKO-4950-mongodb-v7.0 branch from c4bf74b to e1d160f Compare February 25, 2025 14:28
@scality scality deleted a comment from bert-e Feb 25, 2025
@bert-e
Copy link
Contributor

bert-e commented Feb 25, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@benzekrimaha benzekrimaha marked this pull request as ready for review February 25, 2025 14:30
williamlardier
williamlardier reviewed Feb 25, 2025
View reviewed changes
solution-base/mongodb/charts/mongodb-sharded/values.yaml
@@ -520,7 +607,7 @@ configsvr:
serviceAccount:
## @param configsvr.serviceAccount.create Specifies whether a ServiceAccount should be created for Config Server
##
create: false
create: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we want to auto create a service account for the config server, as we maintain it ourselves

solution-base/mongodb/charts/mongodb-sharded/values.yaml
@@ -859,7 +978,7 @@ mongos:
serviceAccount:
## @param mongos.serviceAccount.create Whether to create a Service Account for mongos automatically
##
create: false
create: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

solution-base/mongodb/charts/mongodb-sharded/values.yaml
@@ -1135,7 +1287,7 @@ shardsvr:
serviceAccount:
## @param shardsvr.dataNode.serviceAccount.create Specifies whether a ServiceAccount should be created for shardsvr
##
create: false
create: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

solution-base/mongodb/charts/mongodb-sharded/values.yaml
@@ -1430,7 +1613,7 @@ shardsvr:
serviceAccount:
## @param shardsvr.arbiter.serviceAccount.create Specifies whether a ServiceAccount should be created for shardsvr arbiter nodes
##
create: false
create: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

solution-base/mongodb/charts/mongodb-sharded/charts/common/README.md
- Kubernetes 1.19+
- Helm 3.2.0+
- Kubernetes 1.23+
- Helm 3.8.0+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use helm 3.5 in the dev container and the requirements.sh file, we should bump them to ensure it works

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for KUBECTL_VERSION

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamlardier williamlardier williamlardier left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benzekrimaha @bert-e @williamlardier