-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement/break 8 event add #11
Conversation
Hello benzekrimaha,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
06ac646
to
e4c98b6
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
src/CircuitBreaker.ts
Outdated
this._evaluatingPromiseHook = Promise.allSettled(this._probes.map(p => p.check())); | ||
this._promError = false; | ||
this._evaluatingPromiseHook = Promise.allSettled(this._probes.map(p => p.check().catch(error => { | ||
if (error instanceof Error && error.message === 'Failed to query Prometheus') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why checking this specific kind of error?
whatever the error, it means the breaker is not working as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10949e0
to
d9bd1f2
Compare
026e65d
to
ca46870
Compare
12aae13
to
ccea8fd
Compare
1c03a2f
to
d977da4
Compare
/approve |
I have successfully merged the changeset of this pull request
Please check the status of the associated issue BREAK-8. Goodbye benzekrimaha. The following options are set: approve |
Today what we want is to introduce a new alert when prometheus can't be queried , introducing a new state alters the existing metrics as when these errors happen the state is normally nominal. Introducing the cbError attribute's goal is to let backbeat know an error occured without altering the state / metrics.
Issue: BREAK-8