Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/break 8 event add #11

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented Jun 19, 2024

Today what we want is to introduce a new alert when prometheus can't be queried , introducing a new state alters the existing metrics as when these errors happen the state is normally nominal. Introducing the cbError attribute's goal is to let backbeat know an error occured without altering the state / metrics.

Issue: BREAK-8

@bert-e
Copy link

bert-e commented Jun 19, 2024

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@benzekrimaha benzekrimaha force-pushed the improvement/BREAK-8-event-add branch 2 times, most recently from 06ac646 to e4c98b6 Compare June 19, 2024 15:45
@benzekrimaha benzekrimaha marked this pull request as ready for review June 19, 2024 15:48
@scality scality deleted a comment from bert-e Jun 19, 2024
@bert-e
Copy link

bert-e commented Jun 19, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

this._evaluatingPromiseHook = Promise.allSettled(this._probes.map(p => p.check()));
this._promError = false;
this._evaluatingPromiseHook = Promise.allSettled(this._probes.map(p => p.check().catch(error => {
if (error instanceof Error && error.message === 'Failed to query Prometheus') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why checking this specific kind of error?

whatever the error, it means the breaker is not working as expected

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benzekrimaha benzekrimaha force-pushed the improvement/BREAK-8-event-add branch from 10949e0 to d9bd1f2 Compare June 27, 2024 06:12
@benzekrimaha benzekrimaha force-pushed the improvement/BREAK-8-event-add branch from 026e65d to ca46870 Compare July 1, 2024 06:55
@benzekrimaha benzekrimaha force-pushed the improvement/BREAK-8-event-add branch from 12aae13 to ccea8fd Compare July 3, 2024 10:05
@benzekrimaha benzekrimaha force-pushed the improvement/BREAK-8-event-add branch from 1c03a2f to d977da4 Compare July 5, 2024 14:10
@benzekrimaha
Copy link
Contributor Author

/approve

@bert-e
Copy link

bert-e commented Jul 5, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.0

Please check the status of the associated issue BREAK-8.

Goodbye benzekrimaha.

The following options are set: approve

@bert-e bert-e merged commit d977da4 into development/1.0 Jul 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants