Commit e270b79
fix(icon): clear stale glyph on name change; extract spinner color constant
Addresses review feedback:
- When `name` changes on a mounted Icon to an icon that isn't cached yet, reset
`icon` to undefined so the reserved fallback shows instead of the previous
glyph while the dynamic import resolves.
- Extract the fallback spinner color into a named LOADER_SPINNER_COLOR constant
(mirrors the <Loader> default) instead of an inline magic hex.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent b1df524 commit e270b79
1 file changed
Lines changed: 9 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
79 | 83 | | |
80 | 84 | | |
81 | 85 | | |
| |||
84 | 88 | | |
85 | 89 | | |
86 | 90 | | |
87 | | - | |
| 91 | + | |
88 | 92 | | |
89 | 93 | | |
90 | 94 | | |
| |||
196 | 200 | | |
197 | 201 | | |
198 | 202 | | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
199 | 207 | | |
200 | 208 | | |
201 | 209 | | |
| |||
0 commit comments