Skip to content

Commit a16e9e4

Browse files
committed
Don't export Boost as a dependency of LSL::lsl
Boost is only ever a header-only, PRIVATE compile-time dependency of lslobj (via the lslboost interface target), whether bundled or system- provided. Since lslobj is linked into lsl only through $<BUILD_INTERFACE:lslobj>, this dependency never reaches lsl's exported link interface, so it doesn't belong in lsllinklibs, and the installed LSLConfig.cmake doesn't need find_dependency(Boost) either.
1 parent 892320f commit a16e9e4

2 files changed

Lines changed: 0 additions & 8 deletions

File tree

‎cmake/Dependencies.cmake‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,6 @@ if(NOT LSL_PUGIXML_IS_FETCHED)
8989
endif()
9090
endif()
9191

92-
if(NOT LSL_BUNDLED_BOOST)
93-
list(APPEND lsllinklibs Boost::boost Boost::disable_autolinking)
94-
endif()
95-
9692
if(MINGW)
9793
list(APPEND lsllinklibs bcrypt)
9894
endif()

‎cmake/LSLConfig.cmake.in‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,6 @@ include(CMakeFindDependencyMacro)
44

55
find_dependency(Threads)
66

7-
if(NOT @LSL_BUNDLED_BOOST@)
8-
find_dependency(Boost)
9-
endif()
10-
117
if(NOT @LSL_FETCH_PUGIXML@)
128
find_dependency(pugixml)
139
endif()

0 commit comments

Comments
 (0)