Allow setting of config file path without requiring environment variables.#234
Closed
zeyus wants to merge 4 commits into
Closed
Allow setting of config file path without requiring environment variables.#234zeyus wants to merge 4 commits into
zeyus wants to merge 4 commits into
Conversation
Contributor
Author
|
@cboulay is there something I should do differently for this PR? Or is it not functionality that you would be interested in adding? |
Collaborator
|
Hi @zeyus |
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On non-desktop platforms, often apps are sandboxed and don't have (read/write) access at all to
$HOME,/etc/or even the current working directory. These paths may not exist.In addition, environment variables don't necessarily make a lot of sense in the context of a mobile app, and the application data paths might contain GUIDs or other aspects of the path that make it difficult to determine at compile-time.
This PR adds the ability to set a configuration file path for
liblslprovided that the static member functionlsl_set_config_filenameis called before any other LSL function.In addition, there's also an option to read config directly from a string stream via
set_api_config_contentwhich is loaded into theINIand discarded.