Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Integrate BannerJS module #6

@studioph

Description

@studioph

Currently, the BannerJS module utilized by Banner Proxy is not installed to node_modules folder as to decouple the version being used. However, this causes problems when running the CI unit tests workflow since the cache does a require of banner:

if (typeof(Banner) === 'undefined'){
var Banner = require('banner');
}

which gets executed when rewiring the module for testing:
const index = rewire('../index');

if (typeof(cache) === 'undefined'){
var cache = require('./cache');
}

Since the banner module does not exist, the workflow fails.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions