Skip to content

Commit 1f4e449

Browse files
committed
Allow using hosted Redis instances by default
Hosted Redis servers use self signed certificates (because they do not own the domain they're running on such as `compute-1.amazonaws.com`) therefore a full SSL connection verification will fail. The fix for that behavior is to disable verification so a self signed certificate can be used [docs from a hosted Redis/Key-value store provider](https://devcenter.heroku.com/articles/connecting-heroku-redis#connecting-in-ruby). This PR makes the default behavior to allow connecting to self signed Redis servers. This failing SSL connection behavior was originally reported in Shopify#292, however that issue focuses on raising visibility of such failures. This is an alternative to Shopify#293 that does not introduce a new configuration flag.
1 parent b52f21b commit 1f4e449

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

ruby/lib/ci/queue/redis/base.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ def initialize(redis_url, config)
3939
# it makes sense to retry for a while before giving up.
4040
reconnect_attempts: reconnect_attempts,
4141
middlewares: custom_middlewares,
42+
ssl_params: { verify_mode: OpenSSL::SSL::VERIFY_NONE },
4243
custom: custom_config,
4344
)
4445
else

0 commit comments

Comments
 (0)