Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Valkyrie: double_combo FileSet Derivatives don't get copied over #206

Closed
1 of 2 tasks
ShanaLMoore opened this issue Apr 26, 2024 · 2 comments
Closed
1 of 2 tasks
Assignees
Labels
bug something isn't working high priority Hyku Prime

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Apr 26, 2024

Summary

⚠️ Reference this branch for your base, if it hasn't already been merged into main. ⚠️ [ this branch has since been merged ]

While LaRita was working on the derivative issues in IiifPrint, she noticed that we missed the mark when implementing file sets for valkyrie in the double_combo!

Currently, we are copying over the thumbnail for the fileset but none of its derivatives. That means that they will be lost during the lazy migration (fedora => valkyrie on a record save). We must fix this.

Collection thumbnails (currently handled about the same as a derivative) should be migrated via a rake task, as Collection thumbnails are no longer supported in Hyrax.

Hopefully we can leverage what LaRita has learned by working on this ticket:

Acceptance Criteria

  • Fedora based derivatives should be transferred to valkyrie objects, when a user edits/saves a pre-existing fedora record.

Screenshots or Video

Testing Instructions

Notes

this is a duplicate of samvera/hyrax#6791 - the work will need to go into Hyrax.

@ShanaLMoore ShanaLMoore added the bug something isn't working label Apr 26, 2024
@ShanaLMoore ShanaLMoore changed the title Valkyrie: FileSet Derivatives don't get copied over 🐛 Valkyrie: FileSet Derivatives don't get copied over Apr 26, 2024
@ShanaLMoore ShanaLMoore changed the title 🐛 Valkyrie: FileSet Derivatives don't get copied over 🐛 Valkyrie: double_combo FileSet Derivatives don't get copied over Apr 29, 2024
@laritakr laritakr assigned laritakr and unassigned laritakr Apr 30, 2024
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented May 13, 2024

TODO

update freya adapater to find the derivatives in addition to the thumbnails.

@laritakr
Copy link
Contributor

laritakr commented May 21, 2024

Pull request is in draft, pending some way of testing it... samvera/hyrax#6807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working high priority Hyku Prime
Projects
None yet
Development

No branches or pull requests

2 participants