update expectation for replacing zyte_api_response attribute

Author: BurnzZ

scrapy_zyte_api/responses.py

@@ -15,12 +15,8 @@ def __init__(self, *args, zyte_api_response: Dict = None, **kwargs):
     def replace(self, *args, **kwargs):
         """Create a new response with the same attributes except for those given
         new values.
-
-        NOTE: This doesn't support replacing the ``zyte_api_response`` attribute.
         """
-        instance = super().replace(*args, **kwargs)
-        instance._zyte_api_response = self.zyte_api_response
-        return instance
+        return super().replace(*args, **kwargs)
 
     @property
     def zyte_api_response(self) -> Optional[Dict]:

tests/test_responses.py

@@ -91,14 +91,29 @@ def test_text_from_api_response(api_response, cls):
 def test_response_replace(api_response, cls):
     orig_response = cls.from_api_response(api_response())
 
-    # The ``zyte_api_response`` should not be replaced.
-    new_response = orig_response.replace(zyte_api_response={"overridden": "value"})
-    assert new_response.zyte_api_response == orig_response.zyte_api_response
-
     # It should still work the same way
     new_response = orig_response.replace(status=404)
     assert new_response.status == 404
-    assert new_response.zyte_api_response == orig_response.zyte_api_response
+
+    new_response = orig_response.replace(url="https://new-example.com")
+    assert new_response.url == "https://new-example.com"
+
+
+@pytest.mark.xfail
+@pytest.mark.parametrize(
+    "api_response,cls",
+    [
+        (api_response_browser, ZyteAPITextResponse),
+        (api_response_body, ZyteAPIResponse),
+    ],
+)
+def test_response_replace_zyte_api_response(api_response, cls):
+    orig_response = cls.from_api_response(api_response())
+
+    # The ``zyte_api_response`` should not be replaced.
+    new_zyte_api_response = {"overridden": "value"}
+    new_response = orig_response.replace(zyte_api_response=new_zyte_api_response)
+    assert new_response.zyte_api_response == api_response()
 
 
 def test_non_utf8_response():