Fix/missing character info maintenance (#666)

* feat: Add GetMissingCharacterInfos job to handle missing character information

It could happen that refresh_tokens were present but the character was not. This may cause errors

This addresses #665

* fix: Update database port configuration in phpunit.xml and tests.yml

* lint

* refactor: Improve type handling and data retrieval in asset and transaction finders

* refactor: Improve formatting of callback function in ThroughWalletTransactionsFinder

Author: herpaderpaldent

.github/workflows/tests.yml

@@ -21,7 +21,7 @@ jobs:
         coverage: xdebug #optional
     - uses: getong/mariadb-action@v1.1
       with:
-        host port: 3308 # Optional, default value is 3306. The port of host
+        host port: 3306 # Optional, default value is 3306. The port of host
         #container port: 3307 # Optional, default value is 3306. The port of container
         #character set server: 'utf8' # Optional, default value is 'utf8mb4'. The '--character-set-server' option for mysqld
         #collation server: 'utf8_general_ci' # Optional, default value is 'utf8mb4_general_ci'. The '--collation-server' option for mysqld

database/factories/AssetFactory.php

@@ -38,8 +38,8 @@ class AssetFactory extends Factory
     public function definition()
     {
         return [
-            'assetable_id' => $this->faker->numberBetween(), //factory(CharacterInfo::class),
-            'assetable_type' => CharacterInfo::class, //$this->faker->randomElement([CharacterInfo::class, CorporationInfo::class]),
+            'assetable_id' => $this->faker->numberBetween(), // factory(CharacterInfo::class),
+            'assetable_type' => CharacterInfo::class, // $this->faker->randomElement([CharacterInfo::class, CorporationInfo::class]),
             'item_id' => $this->faker->unique()->randomNumber(),
             'is_blueprint_copy' => false,
             'is_singleton' => $this->faker->boolean,

database/factories/CharacterInfoFactory.php

@@ -57,7 +57,7 @@ public function definition()
         return [
             'character_id' => $this->faker->unique()->numberBetween(9000000, 98000000),
             'name' => $this->faker->name,
-            //'corporation_id'  => $this->faker->numberBetween(98000000, 99000000),
+            // 'corporation_id'  => $this->faker->numberBetween(98000000, 99000000),
             'birthday' => $this->faker->iso8601('now'),
             'gender' => $this->faker->randomElement(['male', 'female']),
             'race_id' => $this->faker->randomDigitNotNull,

database/factories/ContractFactory.php

@@ -50,7 +50,7 @@ public function definition()
             'status' => $this->faker->randomElement(['outstanding', 'in_progress', 'finished_issuer', 'finished_contractor', 'finished', 'cancelled', 'rejected', 'failed', 'deleted', 'reversed']),
             'type' => $this->faker->randomElement(['unknown', 'item_exchange', 'auction', 'courier', 'loan']),
 
-            //optionals
+            // optionals
             'buyout' => $this->faker->randomFloat(),
             'collateral' => $this->faker->randomFloat(),
             'date_accepted' => carbon()->addHour(),

database/migrations/2019_09_18_185641_create_corporation_infosTable.php

@@ -38,13 +38,13 @@
     public function up()
     {
         Schema::create('corporation_infos', function (Blueprint $table) {
-            $table->bigIncrements('corporation_id'); //req
-            $table->string('ticker'); //req
-            $table->string('name'); //req
-            $table->bigInteger('member_count'); //req
-            $table->bigInteger('ceo_id'); //req
-            $table->bigInteger('creator_id'); //req
-            $table->float('tax_rate', 10, 2); //req
+            $table->bigIncrements('corporation_id'); // req
+            $table->string('ticker'); // req
+            $table->string('name'); // req
+            $table->bigInteger('member_count'); // req
+            $table->bigInteger('ceo_id'); // req
+            $table->bigInteger('creator_id'); // req
+            $table->float('tax_rate', 10, 2); // req
 
             $table->bigInteger('alliance_id')->nullable();
             $table->dateTime('date_founded')->nullable();

database/migrations/2025_01_02_185356_fix_killmail_items_table.php

@@ -2,8 +2,8 @@
 
 use Illuminate\Database\Migrations\Migration;
 use Illuminate\Database\Schema\Blueprint;
-use Illuminate\Support\Facades\Schema;
 use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Facades\Schema;
 
 return new class extends Migration
 {

phpunit.xml

@@ -17,7 +17,7 @@
     <env name="REDIS_PASSWORD" value="null"/>
     <env name="REDIS_PORT" value="6379"/>
     <env name="DB_HOST" value="127.0.0.1"/>
-    <env name="DB_PORT" value="3308"/>
+    <env name="DB_PORT" value="3306"/>
     <env name="DB_DATABASE" value="testbench"/>
     <env name="DB_USERNAME" value="default"/>
     <env name="DB_PASSWORD" value="secret"/>

src/Commands/CheckJobsCommand.php

@@ -87,7 +87,7 @@ public function handle(): int
             ->each(function (array $job) {
                 // check if any assertion failed
                 if ($job['status'] === 'error') {
-                    //$this->writeAssertionOutput(get_class($job), 'px-2', '<span class="px-2 bg-red text-gray-400 uppercase">error</span>');
+                    // $this->writeAssertionOutput(get_class($job), 'px-2', '<span class="px-2 bg-red text-gray-400 uppercase">error</span>');
                     $this->writeAssertionHeader($job['class'], 'px-2 bg-red text-gray-400 uppercase', 'error');
                 } elseif ($job['status'] === 'warning') {
                     $this->writeAssertionHeader($job['class'], 'px-2 bg-yellow text-gray-400 uppercase', 'warning');

src/EveapiServiceProvider.php

@@ -71,7 +71,7 @@ class EveapiServiceProvider extends ServiceProvider
 
     public function boot(): void
     {
-        //Add Migrations
+        // Add Migrations
         $this->loadMigrationsFrom(__DIR__.'/../database/migrations/');
 
         // Configure the queue dashboard
@@ -149,7 +149,7 @@ public function configureHorizon(): void
                     'processes' => (int) env(self::QUEUE_BALANCING_WORKERS, 4),
                     'block_for' => 5,
                     'timeout' => 120, // 2 minutes
-                    'nice' => 10, //Allowed values are between 0 and 19
+                    'nice' => 10, // Allowed values are between 0 and 19
                     'maxTime' => 3600,
                     'maxJobs' => 1000,
                 ],
@@ -162,7 +162,7 @@ public function configureHorizon(): void
                     'minProcesses' => 1,
                     'maxProcesses' => (int) env(self::QUEUE_BALANCING_WORKERS, 4),
                     'tries' => 1,
-                    'nice' => 10, //Allowed values are between 0 and 19
+                    'nice' => 10, // Allowed values are between 0 and 19
                     'timeout' => 900, // 15 minutes
                     'maxTime' => 3600,
                     'maxJobs' => 1000,
@@ -204,7 +204,7 @@ private function addEventListeners(): void
         Type::observe(TypeObserver::class);
         Group::observe(GroupObserver::class);
 
-        //Character Observers
+        // Character Observers
         CharacterInfo::observe(CharacterInfoObserver::class);
     }
 
@@ -237,7 +237,7 @@ private function addSchedules(): void
             });
 
             // Run Character Affiliation Job every five minutes to updated outdated affiliations.
-            //$schedule->job(new CharacterAffiliationJob)->everyFiveMinutes();
+            // $schedule->job(new CharacterAffiliationJob)->everyFiveMinutes();
             $schedule->call(new RefreshCharacterAffiliationsService)->everyFiveMinutes();
 
             // Cleanup Batches Table

src/Jobs/Contracts/CharacterContractsJob.php

@@ -105,7 +105,7 @@ public function executeJob(): void
                 'status' => $contract->status,
                 'type' => $contract->type,
 
-                //optionals
+                // optionals
                 'buyout' => optional($contract)->buyout,
                 'collateral' => optional($contract)->collateral,
                 'date_accepted' => optional($contract)->date_accepted ? carbon(optional($contract)->date_accepted) : null,