Use sealed mock objects

Author: sebastianbergmann

tests/unit/Event/Dispatcher/DeferringDispatcherTest.php

@@ -28,7 +28,8 @@ public function testCollectsEventsUntilFlush(): void
 
         $subscribableDispatcher
             ->expects($this->never())
-            ->method('dispatch');
+            ->method('dispatch')
+            ->seal();
 
         $deferringDispatcher = new DeferringDispatcher($subscribableDispatcher);
 
@@ -44,7 +45,8 @@ public function testFlushesCollectedEvents(): void
         $subscribableDispatcher
             ->expects($this->once())
             ->method('dispatch')
-            ->with($this->identicalTo($event));
+            ->with($this->identicalTo($event))
+            ->seal();
 
         $deferringDispatcher = new DeferringDispatcher($subscribableDispatcher);
 
@@ -62,7 +64,8 @@ public function testSubscriberCanBeRegistered(): void
         $subscribableDispatcher
             ->expects($this->once())
             ->method('registerSubscriber')
-            ->with($this->identicalTo($subscriber));
+            ->with($this->identicalTo($subscriber))
+            ->seal();
 
         $deferringDispatcher = new DeferringDispatcher($subscribableDispatcher);
 
@@ -78,7 +81,8 @@ public function testTracerCanBeRegistered(): void
         $subscribableDispatcher
             ->expects($this->once())
             ->method('registerTracer')
-            ->with($this->identicalTo($tracer));
+            ->with($this->identicalTo($tracer))
+            ->seal();
 
         $deferringDispatcher = new DeferringDispatcher($subscribableDispatcher);
 

tests/unit/Event/Dispatcher/DirectDispatcherTest.php

@@ -36,7 +36,8 @@ public function testDispatchesEventToKnownSubscribers(): void
         $subscriber
             ->expects($this->once())
             ->method('notify')
-            ->with($this->identicalTo($event));
+            ->with($this->identicalTo($event))
+            ->seal();
 
         $dispatcher->registerSubscriber($subscriber);
 
@@ -55,7 +56,8 @@ public function testDispatchesEventToTracers(): void
         $tracer
             ->expects($this->once())
             ->method('trace')
-            ->with($this->identicalTo($event));
+            ->with($this->identicalTo($event))
+            ->seal();
 
         $dispatcher->registerTracer($tracer);
 

tests/unit/Framework/TestRunner/ChildProcessResultProcessorTest.php

@@ -29,7 +29,8 @@ public function testEmitsErrorEventWhenStderrIsNotEmpty(): void
 
         $emitter
             ->expects($this->once())
-            ->method('testErrored');
+            ->method('testErrored')
+            ->seal();
 
         $this->processor($emitter)->process(new Success('testOne'), '', 'error');
     }
@@ -39,10 +40,19 @@ public function testEmitsErrorEventWhenProcessResultCannotBeUnserialized(): void
     {
         $emitter = $this->createMock(Emitter::class);
 
+        $emitter
+            ->expects($this->once())
+            ->method('childProcessErrored');
+
         $emitter
             ->expects($this->once())
             ->method('testErrored');
 
+        $emitter
+            ->expects($this->once())
+            ->method('testFinished')
+            ->seal();
+
         $this->processor($emitter)->process(new Success('testOne'), '', '');
     }
 
@@ -51,10 +61,19 @@ public function testEmitsErrorEventWhenProcessResultIsShorterThanExpectedNonce()
     {
         $emitter = $this->createMock(Emitter::class);
 
+        $emitter
+            ->expects($this->once())
+            ->method('childProcessErrored');
+
         $emitter
             ->expects($this->once())
             ->method('testErrored');
 
+        $emitter
+            ->expects($this->once())
+            ->method('testFinished')
+            ->seal();
+
         $this->processor($emitter)->process(
             new Success('testOne'),
             'too-short',
@@ -68,10 +87,19 @@ public function testEmitsErrorEventWhenProcessResultNonceDoesNotMatchExpectedNon
     {
         $emitter = $this->createMock(Emitter::class);
 
+        $emitter
+            ->expects($this->once())
+            ->method('childProcessErrored');
+
         $emitter
             ->expects($this->once())
             ->method('testErrored');
 
+        $emitter
+            ->expects($this->once())
+            ->method('testFinished')
+            ->seal();
+
         $this->processor($emitter)->process(
             new Success('testOne'),
             '00000000000000000000000000000000payload',
@@ -85,10 +113,19 @@ public function testEmitsErrorEventWhenProcessResultContainsOnlyExpectedNonceAnd
     {
         $emitter = $this->createMock(Emitter::class);
 
+        $emitter
+            ->expects($this->once())
+            ->method('childProcessErrored');
+
         $emitter
             ->expects($this->once())
             ->method('testErrored');
 
+        $emitter
+            ->expects($this->once())
+            ->method('testFinished')
+            ->seal();
+
         $this->processor($emitter)->process(
             new Success('testOne'),
             'abcdef0123456789abcdef0123456789',